Issue 14847013: Remove obsolete HArrayLiteral instruction.

Issue 14847013: Remove obsolete HArrayLiteral instruction. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger

Modified:
7 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove obsolete HArrayLiteral instruction. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14613

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -356 lines)			Patch
M	src/arm/lithium-arm.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+0 lines, -55 lines	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+39 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+0 lines, -51 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+0 lines, -61 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	src/mips/lithium-mips.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	src/x64/lithium-x64.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/14847013/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/14847013/diff/1/src/hydrogen.cc#newcode6912 src/hydrogen.cc:6912: Handle<FixedArray> constants= isolate()->factory()->empty_fixed_array(); Space before =

7 years, 7 months ago (2013-05-10 08:38:31 UTC) #2

Michael Starzinger

Addressed comments. Will land on top of HObjectLiteral change.

7 years, 7 months ago (2013-05-10 08:44:05 UTC) #3

Michael Starzinger

7 years, 7 months ago (2013-05-10 09:52:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14613 (presubmit successful).

Expand Messages | Collapse Messages