Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: src/stub-cache.cc

Issue 14847004: Turn the load field code stub into a hydrogen code stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 JSObject::UpdateMapCodeCache(receiver, cache_name, handler); 216 JSObject::UpdateMapCodeCache(receiver, cache_name, handler);
217 return handler; 217 return handler;
218 } 218 }
219 219
220 220
221 Handle<Code> StubCache::ComputeLoadField(Handle<Name> name, 221 Handle<Code> StubCache::ComputeLoadField(Handle<Name> name,
222 Handle<JSObject> receiver, 222 Handle<JSObject> receiver,
223 Handle<JSObject> holder, 223 Handle<JSObject> holder,
224 PropertyIndex field) { 224 PropertyIndex field) {
225 if (receiver.is_identical_to(holder)) { 225 if (receiver.is_identical_to(holder)) {
226 LoadFieldStub stub(LoadStubCompiler::receiver(), 226 LoadFieldStub stub(field.is_inobject(holder),
227 field.is_inobject(holder), 227 field.translate(holder),
228 field.translate(holder)); 228 Representation::Tagged());
229 return stub.GetCode(isolate()); 229 return stub.GetCode(isolate());
230 } 230 }
231 231
232 Handle<JSObject> stub_holder = StubHolder(receiver, holder); 232 Handle<JSObject> stub_holder = StubHolder(receiver, holder);
233 Handle<Code> stub = FindHandler( 233 Handle<Code> stub = FindHandler(
234 name, receiver, stub_holder, Code::LOAD_IC, Code::FIELD); 234 name, receiver, stub_holder, Code::LOAD_IC, Code::FIELD);
235 if (!stub.is_null()) return stub; 235 if (!stub.is_null()) return stub;
236 236
237 LoadStubCompiler compiler(isolate_); 237 LoadStubCompiler compiler(isolate_);
238 Handle<Code> handler = 238 Handle<Code> handler =
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 JSObject::UpdateMapCodeCache(stub_holder, name, ic); 332 JSObject::UpdateMapCodeCache(stub_holder, name, ic);
333 return ic; 333 return ic;
334 } 334 }
335 335
336 336
337 Handle<Code> StubCache::ComputeKeyedLoadField(Handle<Name> name, 337 Handle<Code> StubCache::ComputeKeyedLoadField(Handle<Name> name,
338 Handle<JSObject> receiver, 338 Handle<JSObject> receiver,
339 Handle<JSObject> holder, 339 Handle<JSObject> holder,
340 PropertyIndex field) { 340 PropertyIndex field) {
341 if (receiver.is_identical_to(holder)) { 341 if (receiver.is_identical_to(holder)) {
342 LoadFieldStub stub(KeyedLoadStubCompiler::receiver(), 342 KeyedLoadFieldStub stub(field.is_inobject(holder),
343 field.is_inobject(holder), 343 field.translate(holder),
344 field.translate(holder)); 344 Representation::Tagged());
345 return stub.GetCode(isolate()); 345 return stub.GetCode(isolate());
346 } 346 }
347 347
348 Handle<JSObject> stub_holder = StubHolder(receiver, holder); 348 Handle<JSObject> stub_holder = StubHolder(receiver, holder);
349 Handle<Code> stub = FindHandler( 349 Handle<Code> stub = FindHandler(
350 name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::FIELD); 350 name, receiver, stub_holder, Code::KEYED_LOAD_IC, Code::FIELD);
351 if (!stub.is_null()) return stub; 351 if (!stub.is_null()) return stub;
352 352
353 KeyedLoadStubCompiler compiler(isolate_); 353 KeyedLoadStubCompiler compiler(isolate_);
354 Handle<Code> handler = 354 Handle<Code> handler =
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
1518 1518
1519 1519
1520 Handle<Code> BaseLoadStubCompiler::CompileLoadField(Handle<JSObject> object, 1520 Handle<Code> BaseLoadStubCompiler::CompileLoadField(Handle<JSObject> object,
1521 Handle<JSObject> holder, 1521 Handle<JSObject> holder,
1522 Handle<Name> name, 1522 Handle<Name> name,
1523 PropertyIndex field) { 1523 PropertyIndex field) {
1524 Label miss; 1524 Label miss;
1525 1525
1526 Register reg = HandlerFrontendHeader(object, receiver(), holder, name, &miss); 1526 Register reg = HandlerFrontendHeader(object, receiver(), holder, name, &miss);
1527 1527
1528 LoadFieldStub stub(reg, field.is_inobject(holder), field.translate(holder)); 1528 GenerateLoadField(reg, holder, field);
1529 GenerateTailCall(masm(), stub.GetCode(isolate()));
1530 1529
1531 __ bind(&miss); 1530 __ bind(&miss);
1532 TailCallBuiltin(masm(), MissBuiltin(kind())); 1531 TailCallBuiltin(masm(), MissBuiltin(kind()));
1533 1532
1534 // Return the generated code. 1533 // Return the generated code.
1535 return GetCode(kind(), Code::FIELD, name); 1534 return GetCode(kind(), Code::FIELD, name);
1536 } 1535 }
1537 1536
1538 1537
1539 // Load a fast property out of a holder object (src). In-object properties 1538 // Load a fast property out of a holder object (src). In-object properties
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 void BaseLoadStubCompiler::GenerateLoadPostInterceptor( 1603 void BaseLoadStubCompiler::GenerateLoadPostInterceptor(
1605 Register interceptor_reg, 1604 Register interceptor_reg,
1606 Handle<JSObject> interceptor_holder, 1605 Handle<JSObject> interceptor_holder,
1607 Handle<Name> name, 1606 Handle<Name> name,
1608 LookupResult* lookup) { 1607 LookupResult* lookup) {
1609 Label success; 1608 Label success;
1610 Handle<JSObject> holder(lookup->holder()); 1609 Handle<JSObject> holder(lookup->holder());
1611 if (lookup->IsField()) { 1610 if (lookup->IsField()) {
1612 PropertyIndex field = lookup->GetFieldIndex(); 1611 PropertyIndex field = lookup->GetFieldIndex();
1613 if (interceptor_holder.is_identical_to(holder)) { 1612 if (interceptor_holder.is_identical_to(holder)) {
1614 LoadFieldStub stub(interceptor_reg, 1613 GenerateLoadField(interceptor_reg, holder, field);
1615 field.is_inobject(holder),
1616 field.translate(holder));
1617 GenerateTailCall(masm(), stub.GetCode(isolate()));
1618 } else { 1614 } else {
1619 // We found FIELD property in prototype chain of interceptor's holder. 1615 // We found FIELD property in prototype chain of interceptor's holder.
1620 // Retrieve a field from field's holder. 1616 // Retrieve a field from field's holder.
1621 Register reg = HandlerFrontend( 1617 Register reg = HandlerFrontend(
1622 interceptor_holder, interceptor_reg, holder, name, &success); 1618 interceptor_holder, interceptor_reg, holder, name, &success);
1623 __ bind(&success); 1619 __ bind(&success);
1624 GenerateLoadField(reg, holder, field); 1620 GenerateLoadField(reg, holder, field);
1625 } 1621 }
1626 } else { 1622 } else {
1627 // We found CALLBACKS property in prototype chain of interceptor's 1623 // We found CALLBACKS property in prototype chain of interceptor's
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
2116 Handle<FunctionTemplateInfo>( 2112 Handle<FunctionTemplateInfo>(
2117 FunctionTemplateInfo::cast(signature->receiver())); 2113 FunctionTemplateInfo::cast(signature->receiver()));
2118 } 2114 }
2119 } 2115 }
2120 2116
2121 is_simple_api_call_ = true; 2117 is_simple_api_call_ = true;
2122 } 2118 }
2123 2119
2124 2120
2125 } } // namespace v8::internal 2121 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698