runtime/bin/builtin_natives.cc - Issue 1484653002: Fixes setjmp clobbering warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/builtin_natives.cc

Issue 1484653002: Fixes setjmp clobbering warnings. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/builtin_natives.cc

diff --git a/runtime/bin/builtin_natives.cc b/runtime/bin/builtin_natives.cc

index 19a25d2a3ab8fd20363006439828f92bb950ba4d..5ba56371a4d78a8f87f457f210fed8370f807969 100644

--- a/runtime/bin/builtin_natives.cc

+++ b/runtime/bin/builtin_natives.cc

@@ -91,7 +91,8 @@ void FUNCTION_NAME(Builtin_PrintString)(Dart_NativeArguments args) {

if (Dart_IsError(result)) Dart_PropagateError(result);

// Uses fwrite to support printing NUL bytes.

- fwrite(chars, 1, length, stdout);

+ intptr_t res = fwrite(chars, 1, length, stdout);

+ ASSERT(res == length);

fputs("\n", stdout);

fflush(stdout);

if (ShouldCaptureStdout()) {

« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »