Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1484653002: Fixes setjmp clobbering warnings. (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
Bill Hesse, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes setjmp clobbering warnings. Also fixes an unused result warning. BUG=https://github.com/dart-lang/sdk/issues/25052 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c888f04ba360a09d3f8d215eb5dbc1a3fab0ee43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
5 years ago (2015-11-28 06:53:03 UTC) #3
Bill Hesse
lgtm
5 years ago (2015-11-28 15:19:36 UTC) #5
zra
5 years ago (2015-11-28 22:01:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c888f04ba360a09d3f8d215eb5dbc1a3fab0ee43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698