Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 148463008: Update is-valid flag upon resetting input elements. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update is-valid flag upon resetting input elements. If the value of an input element is reset back to empty, make sure we sync its is-valid flag when doing so. If not, form control elements marked as 'required' may end up being incorrectly labelled as valid. R= BUG=336818 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165942

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switch test over to use js-test.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
A LayoutTests/fast/forms/file/file-input-reset-validation.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/file/file-input-reset-validation-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
When you next have a spare moment, please take a look.
6 years, 10 months ago (2014-01-28 10:29:10 UTC) #1
tkent
lgtm https://codereview.chromium.org/148463008/diff/1/LayoutTests/fast/forms/file/file-input-reset-validation.html File LayoutTests/fast/forms/file/file-input-reset-validation.html (right): https://codereview.chromium.org/148463008/diff/1/LayoutTests/fast/forms/file/file-input-reset-validation.html#newcode9 LayoutTests/fast/forms/file/file-input-reset-validation.html:9: function log(message) nit: I recommend to use js-test.js.
6 years, 10 months ago (2014-01-28 11:05:46 UTC) #2
sof
Thanks (giving it a go if the trybots still return green.) https://codereview.chromium.org/148463008/diff/1/LayoutTests/fast/forms/file/file-input-reset-validation.html File LayoutTests/fast/forms/file/file-input-reset-validation.html (right): ...
6 years, 10 months ago (2014-01-28 11:38:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/148463008/20001
6 years, 10 months ago (2014-01-28 12:13:22 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 15:25:42 UTC) #5
Message was sent while issue was closed.
Change committed as 165942

Powered by Google App Engine
This is Rietveld 408576698