Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/bots/pub.py

Issue 148463007: Add builder_tag option to tools/test.dart (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/bot.py ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/pub.py
===================================================================
--- tools/bots/pub.py (revision 32052)
+++ tools/bots/pub.py (working copy)
@@ -15,7 +15,7 @@
import bot
-PUB_BUILDER = r'pub-(linux|mac|win)(-russian)?'
+PUB_BUILDER = r'pub-(linux|mac|win)(-(russian))?'
def PubConfig(name, is_buildbot):
"""Returns info for the current buildbot based on the name of the builder.
@@ -29,9 +29,11 @@
return None
system = pub_pattern.group(1)
+ locale = pub_pattern.group(3)
if system == 'win': system = 'windows'
- return bot.BuildInfo('none', 'vm', 'release', system, checked=True)
+ return bot.BuildInfo('none', 'vm', 'release', system, checked=True,
+ builder_tag=locale)
def PubSteps(build_info):
@@ -41,17 +43,19 @@
print 'Building package-root: %s' % (' '.join(args))
bot.RunProcess(args)
- bot.RunTest('pub', build_info, ['--write-test-outcome-log',
- 'pub', 'pkg', 'dartdoc', 'docs'])
+ common_args = ['--write-test-outcome-log']
+ if build_info.builder_tag:
+ common_args.append('--builder-tag=%s' % build_info.builder_tag)
+
+ bot.RunTest('pub', build_info,
+ common_args + ['pub', 'pkg', 'dartdoc', 'docs'])
pkgbuild_build_info = bot.BuildInfo('none', 'vm', 'release',
build_info.system, checked=False)
bot.RunTest('pkgbuild_repo_pkgs', pkgbuild_build_info,
- ['--append_logs', '--write-test-outcome-log',
- '--use-repository-packages', 'pkgbuild'])
+ common_args + ['--append_logs', '--use-repository-packages', 'pkgbuild'])
bot.RunTest('pkgbuild_public_pkgs', pkgbuild_build_info,
- ['--append_logs', '--write-test-outcome-log',
- '--use-public-packages', 'pkgbuild'])
+ common_args + ['--append_logs', '--use-public-packages', 'pkgbuild'])
if __name__ == '__main__':
bot.RunBot(PubConfig, PubSteps)
« no previous file with comments | « tools/bots/bot.py ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698