libaddressinput - reduce number of copies in storage class by 2

base/values.h

Index: base/values.h
diff --git a/base/values.h b/base/values.h
index 8caf8350a8bfc76b00b96044213b55912466031f..3df0f9257cb4ad129eb9c23475c2cfd97d5ffb40 100644
--- a/base/values.h
+++ b/base/values.h
@@ -91,6 +91,7 @@ class BASE_EXPORT Value {
   virtual bool GetAsDouble(double* out_value) const;
   virtual bool GetAsString(std::string* out_value) const;
   virtual bool GetAsString(string16* out_value) const;
+  virtual bool GetAsString(const StringValue** out_value) const;
   virtual bool GetAsList(ListValue** out_value);
   virtual bool GetAsList(const ListValue** out_value) const;
   virtual bool GetAsDictionary(DictionaryValue** out_value);
@@ -154,9 +155,14 @@ class BASE_EXPORT StringValue : public Value {
 
   virtual ~StringValue();
 
+  // Returns a reference to |value_|.

[Dan Beam, 2014/01/30 03:57:58]

^ needs updating it seems

+  std::string* GetString();
+  const std::string& GetString() const;
+
   // Overridden from Value:
   virtual bool GetAsString(std::string* out_value) const OVERRIDE;
   virtual bool GetAsString(string16* out_value) const OVERRIDE;
+  virtual bool GetAsString(const StringValue** out_value) const OVERRIDE;
   virtual StringValue* DeepCopy() const OVERRIDE;
   virtual bool Equals(const Value* other) const OVERRIDE;