Add Views implementation of ProfileSigninConfirmationDialog.

chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h

Index: chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h
diff --git a/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h b/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h
index 08bc0932e1cb4f33efa9630d24cc7bf48ffab9c1..f60d953cef36d854d610d7cb202f3e53c37d196d 100644
--- a/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h
+++ b/chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h
@@ -8,10 +8,10 @@
 #include <string>
 
 #include "base/callback.h"
-#include "base/memory/weak_ptr.h"
 #include "base/string16.h"
 #include "chrome/browser/common/cancelable_request.h"
 #include "chrome/browser/history/history_types.h"
+#include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
@@ -23,19 +23,14 @@ class WebUIMessageHandler;
 // to create a new Chrome profile.
 class ProfileSigninConfirmationDialog : public ui::WebDialogDelegate {
  public:
-  // Creates and shows the modal dialog.  |profile| is the current Chrome
-  // profile and |username| is the GAIA username that the user is signing
-  // in with.
-  static void ShowDialog(Profile* profile,
-                         const std::string& username,
-                         const base::Closure& cancel_signin,
-                         const base::Closure& signin_with_new_profile,
-                         const base::Closure& continue_signin);
-
   // Closes the dialog, which will delete itself.
   void Close() const;
 
  private:
+  friend void chrome::ShowProfileSigninConfirmationDialog(

[James Hawkins, 2013/05/07 17:22:44]

Why is this necessary?

[dconnelly, 2013/05/07 17:31:30]

This class has a private constructor and destructor and the friend function
isn't part of the class.

The friend function is declared once in browser_dialogs.h and is (will be)
defined per-platform to show the right implementation.  I'm happy to use a
different approach, this is just the one suggested by ben@ in an aborted
refactoring CL.

+      Profile*, const std::string&,
+      const base::Closure&, const base::Closure&, const base::Closure&);
+
   ProfileSigninConfirmationDialog(
       Profile* profile,
       const std::string& username,
@@ -83,8 +78,6 @@ class ProfileSigninConfirmationDialog : public ui::WebDialogDelegate {
   // label on GetWebUIMessageHandlers.
   mutable bool closed_by_handler_;
 
-  base::WeakPtrFactory<ProfileSigninConfirmationDialog> weak_pointer_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationDialog);
 };