Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 14846016: Add asan=1 gyp defines to asan bot (Closed)

Created:
7 years, 7 months ago by Isaac (away)
Modified:
7 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, Siva Chandra
Visibility:
Public.

Description

Add asan=1 gyp defines to asan bot Fixes asan bot and uses slave_props for extra_gyp_defines. BUG=160952 TBR=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198674

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/buildbot/bb_run_bot.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/buildbot/buildbot_functions.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Isaac (away)
+cc siva: this is how I wanted to define extra_gyp_defines for the component build. We ...
7 years, 7 months ago (2013-05-07 09:27:03 UTC) #1
Isaac (away)
Committed patchset #1 manually as r198674.
7 years, 7 months ago (2013-05-07 09:27:51 UTC) #2
iannucci
7 years, 7 months ago (2013-05-07 18:05:56 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698