chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc - Issue 14846004: Migrate ProxyConfigServiceImpl to NetworkStateHandler and NetworkProfileHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 14846004: Migrate ProxyConfigServiceImpl to NetworkStateHandler and NetworkProfileHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

index b50afacf46841d3aeaff1ea2ed28717bc2b07120..22ab8382e39f5465bb9310d99c20d8c771a04a4d 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

@@ -16,6 +16,7 @@

#include "chrome/browser/chromeos/proxy_config_service_impl.h"

#include "chrome/browser/chromeos/proxy_cros_settings_parser.h"

#include "chrome/browser/chromeos/settings/cros_settings.h"

+#include "chrome/browser/chromeos/ui_proxy_config_service.h"

#include "chrome/browser/policy/browser_policy_connector.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/chromeos/ui_account_tweaks.h"

@@ -94,7 +95,7 @@ CoreChromeOSOptionsHandler::CoreChromeOSOptionsHandler()

CoreChromeOSOptionsHandler::~CoreChromeOSOptionsHandler() {

PrefProxyConfigTracker* proxy_tracker =

Profile::FromWebUI(web_ui())->GetProxyConfigTracker();

- proxy_tracker->RemoveNotificationCallback(

+ proxy_tracker->GetUIService().RemoveNotificationCallback(

base::Bind(&CoreChromeOSOptionsHandler::NotifyProxyPrefsChanged,

pointer_factory_.GetWeakPtr()));

}

@@ -111,7 +112,7 @@ void CoreChromeOSOptionsHandler::InitializeHandler() {

// Observe the chromeos::ProxyConfigServiceImpl for changes from the UI.

PrefProxyConfigTracker* proxy_tracker =

Profile::FromWebUI(web_ui())->GetProxyConfigTracker();

- proxy_tracker->AddNotificationCallback(

+ proxy_tracker->GetUIService().AddNotificationCallback(

base::Bind(&CoreChromeOSOptionsHandler::NotifyProxyPrefsChanged,

pointer_factory_.GetWeakPtr()));

}