chromeos/network/managed_state.h - Issue 14846004: Migrate ProxyConfigServiceImpl to NetworkStateHandler and NetworkProfileHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/managed_state.h

Issue 14846004: Migrate ProxyConfigServiceImpl to NetworkStateHandler and NetworkProfileHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Mattias' comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/chromeos/login/network_state_informer.cc ('K') | « chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/managed_state.h

diff --git a/chromeos/network/managed_state.h b/chromeos/network/managed_state.h

index c7964a3b6d09d36a9568e580451d6d1d2dc457c1..dd88fa70521b33e53342824096a55d172c73eab5 100644

--- a/chromeos/network/managed_state.h

+++ b/chromeos/network/managed_state.h

@@ -40,8 +40,10 @@ class ManagedState {

NetworkState* AsNetworkState();

DeviceState* AsDeviceState();

- // Called by NetworkStateHandler when a property changes. Returns true if

- // the property was recognized and parsed successfully.

+ // Called by NetworkStateHandler when a property was received. The return

+ // value only guarantees: If false then the state wasn't modified (e.g. if the

+ // property wasn't parsed successfully).

+ // I.e. if it returns true, the state might be modified or not.

virtual bool PropertyChanged(const std::string& key,

const base::Value& value) = 0;