content/renderer/input/input_handler_proxy.cc - Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/input/input_handler_proxy.cc

Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address jdduke's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input/synthetic_web_input_event_builders.cc ('k') | content/renderer/input/input_handler_proxy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/input/input_handler_proxy.cc

diff --git a/content/renderer/input/input_handler_proxy.cc b/content/renderer/input/input_handler_proxy.cc

index 7a66730c4f43d9c7a28f137ba001b7b4f8a804c1..763e0d97374f2cc9def1b8e4c37ed517094fb8b8 100644

--- a/content/renderer/input/input_handler_proxy.cc

+++ b/content/renderer/input/input_handler_proxy.cc

@@ -13,6 +13,7 @@

#include "third_party/WebKit/public/web/WebInputEvent.h"

#include "ui/events/latency_info.h"

#include "ui/gfx/frame_time.h"

+#include "ui/gfx/geometry/point_conversions.h"

using blink::WebFloatPoint;

using blink::WebFloatSize;

@@ -231,8 +232,8 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleInputEvent(

if (touch_event.touches[i].state != WebTouchPoint::StatePressed)

continue;

if (input_handler_->HaveTouchEventHandlersAt(

- blink::WebPoint(touch_event.touches[i].position.x,

- touch_event.touches[i].position.y))) {

+ gfx::Point(touch_event.touches[i].position.x,

+ touch_event.touches[i].position.y))) {

return DID_NOT_HANDLE;

}