content/browser/renderer_host/ui_events_helper.cc - Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ui_events_helper.cc

Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address jdduke's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_event_queue_unittest.cc ('k') | content/common/input/synthetic_web_input_event_builders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/ui_events_helper.cc

diff --git a/content/browser/renderer_host/ui_events_helper.cc b/content/browser/renderer_host/ui_events_helper.cc

index 1aa5f9027f8f1caced401ed91a1c08433edc5fcd..8c2a9a9ee445c4fbf23744243f09822a953d2fa9 100644

--- a/content/browser/renderer_host/ui_events_helper.cc

+++ b/content/browser/renderer_host/ui_events_helper.cc

@@ -121,11 +121,11 @@ bool MakeUITouchEventsFromWebTouchEvents(

if (WebTouchPointStateToEventType(point.state) != type)

continue;

// ui events start in the co-ordinate space of the EventDispatcher.

- gfx::Point location;

+ gfx::PointF location;

if (coordinate_system == LOCAL_COORDINATES)

- location = gfx::Point(point.position.x, point.position.y);

+ location = point.position;

else

- location = gfx::Point(point.screenPosition.x, point.screenPosition.y);

+ location = point.screenPosition;

ui::TouchEvent* uievent = new ui::TouchEvent(type,

location,

flags,