ports/SkFontHost_mac.cpp - Issue 148453005: Calculate Underline thickness for Skia from Font metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ports/SkFontHost_mac.cpp

Issue 148453005: Calculate Underline thickness for Skia from Font metrics (Closed) Base URL: https://chromium.googlesource.com/external/skia/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ports/SkFontHost_mac.cpp

diff --git a/ports/SkFontHost_mac.cpp b/ports/SkFontHost_mac.cpp

index fe3fd069817be56a3406d2b03c57ca7882812e91..b465ecd1eb58172a3162a6cdd91d3554daf2cecd 100755

--- a/ports/SkFontHost_mac.cpp

+++ b/ports/SkFontHost_mac.cpp

@@ -1379,6 +1379,7 @@ void SkScalerContext_Mac::generateFontMetrics(SkPaint::FontMetrics* mx,

theMetrics.fXMin = CGToScalar( CGRectGetMinX_inline(theBounds));

theMetrics.fXMax = CGToScalar( CGRectGetMaxX_inline(theBounds));

theMetrics.fXHeight = CGToScalar( CTFontGetXHeight(fCTFont));

+ theMetrics.fUnderlineThickness = CGToScalar(CTFontGetUnderlineThickness(fCTFont));

if (mx != NULL) {

*mx = theMetrics;

« no previous file with comments | « ports/SkFontHost_FreeType.cpp ('k') | no next file » | no next file with comments »