Issue 14845020: Ignore unwanted AddRef/ReleaesModule calls to g_browser_process from the views layer during startup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14845020: Ignore unwanted AddRef/ReleaesModule calls to g_browser_process from the views layer during startup. (Closed)

Created:
7 years, 7 months ago by robertshield

Modified:
7 years, 7 months ago

Reviewers:
msw, sky, grt (UTC plus 2)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore unwanted AddRef/ReleaesModule calls to g_browser_process from the views layer during startup. BUG=241366 TEST=Uninstall Chrome while it is set as the default browser. Select an item from the "make other browser default" combobox. Observe that the dialog does not immediately close.

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -3 lines)			Patch
M	chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	ui/views/test/test_views_delegate.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/views_delegate.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

robertshield

7 years, 7 months ago (2013-05-16 21:57:26 UTC) #1

An alternate fix for https://codereview.chromium.org/15134004/

Expand Messages | Collapse Messages