Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: test/cctest/cctest.status

Issue 14845018: Allow for no samples in test-cpu-profiler/SampleWhenFrameIsNotSetup (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index 91c6d7015f1251f97c353f7de15ed5ba08ecc6d6..731e54d07c212cd26125ef5e9e7479d7c48f1fb0 100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -39,10 +39,6 @@ test-api/ApplyInterruption: PASS || TIMEOUT
# when snapshot is on, so I am marking it PASS || FAIL
test-heap-profiler/HeapSnapshotsDiff: PASS || FAIL
-# BUG(2628): These tests are flaky and sometimes fail, but should not crash.
-test-cpu-profiler/CollectCpuProfile: PASS || FAIL
-test-cpu-profiler/SampleWhenFrameIsNotSetup: PASS || FAIL
-
# These tests always fail. They are here to test test.py. If
# they don't fail then test.py has failed.
test-serialize/TestThatAlwaysFails: FAIL
@@ -87,7 +83,8 @@ test-serialize/DeserializeFromSecondSerialization: SKIP
# BUG(2628): Signal may come when pc is close to frame enter/exit code and on
# simulator the stack frame is not set up when it is expected to be for the pc
# value.
-test-cpu-profiler/SampleWhenFrameIsNotSetup: SKIP
+test-cpu-profiler/CollectCpuProfile: PASS || FAIL
+test-cpu-profiler/SampleWhenFrameIsNotSetup: PASS || FAIL
##############################################################################
[ $arch == android_arm || $arch == android_ia32 ]
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698