Allow for no samples in test-cpu-profiler/SampleWhenFrameIsNotSetup

Allow for no samples in test-cpu-profiler/SampleWhenFrameIsNotSetup

The test should only check that there are no sample stacks that never possible in the JS code being profiled.

BUG=v8:2628
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14723

[Sven Panne, 2013-05-17 06:53:57]

lgtm

[yurys, 2013-05-17 15:10:33]

Committed patchset #2 manually as r14723 (presubmit successful).

[Sven Panne, 2013-05-21 10:38:29]

Hmmm, somehow SampleWhenFrameIsNotSetup is still flaky, CheckChildrenNames is
unconditionally called and sometimes has a failing CHECK. A new fix would be
highly appreciated, otherwise we'll have to disable the test again.

[yurys, 2013-05-23 05:08:47]

On 2013/05/21 10:38:29, Sven Panne wrote:
> Hmmm, somehow SampleWhenFrameIsNotSetup is still flaky, CheckChildrenNames is
> unconditionally called and sometimes has a failing CHECK. A new fix would be
> highly appreciated, otherwise we'll have to disable the test again.

This is weird. Do you remember what was the unexpected node under root? I didn't
see this locally.

[yurys, 2013-05-23 05:24:22]

On 2013/05/23 05:08:47, Yury Semikhatsky wrote:
> On 2013/05/21 10:38:29, Sven Panne wrote:
> > Hmmm, somehow SampleWhenFrameIsNotSetup is still flaky, CheckChildrenNames
is
> > unconditionally called and sometimes has a failing CHECK. A new fix would be
> > highly appreciated, otherwise we'll have to disable the test again.
> 
> This is weird. Do you remember what was the unexpected node under root? I
didn't
> see this locally.

Ok, I see it failed on windows but not sure why, the profile dumped looks fine
and should have passed all the checks in the test, will investigate:

=== cctest/test-cpu-profiler/SampleWhenFrameIsNotSetup ===
--- stdout ---
[Top down]:
    2     0   (root) [-1] #1
    2     2    (program) [-1] #2
Command: E:\b\build\slave\v8-win32\build\v8\build\Release\cctest.exe
test-cpu-profiler/SampleWhenFrameIsNotSetup --nobreak-on-abort
--nodead-code-elimination --nofold-constants
--testing_serialization_file=E:\b\build\slave\v8-win32\build\v8\out\.serdes\serdes_test-cpu-profiler/SampleWhenFrameIsNotSetup