Issue 14845012: More typed array constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14845012: More typed array constructors. (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

More typed array constructors. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14518

Patch Set 1 : Patch #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -1 line)			Patch
M	src/messages.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/typedarray.js	View	1 chunk	+16 lines, -1 line	1 comment	Download
M	test/mjsunit/harmony/typedarrays.js	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

This add more typed array constrcutors. I _think_ we should be at feature parity after ...

7 years, 7 months ago (2013-05-02 11:42:36 UTC) #1

rossberg

lgtm https://codereview.chromium.org/14845012/diff/2001/src/typedarray.js File src/typedarray.js (right): https://codereview.chromium.org/14845012/diff/2001/src/typedarray.js#newcode126 src/typedarray.js:126: function TryConstructByArrayLike(obj, arrayLike) { Nit: why is this ...

7 years, 7 months ago (2013-05-02 11:52:20 UTC) #2

Dmitry Lomov (no reviews)

On 2013/05/02 11:52:20, rossberg wrote: > lgtm > > https://codereview.chromium.org/14845012/diff/2001/src/typedarray.js > File src/typedarray.js (right): > ...

7 years, 7 months ago (2013-05-02 12:19:22 UTC) #3

Dmitry Lomov (no reviews)

7 years, 7 months ago (2013-05-02 12:27:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14518 (presubmit successful).

Expand Messages | Collapse Messages