Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14845011: Enable tcmalloc's logging in Android. (Closed)

Created:
7 years, 7 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M third_party/tcmalloc/chromium/src/base/logging.h View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dai Mikurube (NOT FULLTIME)
I think it's ready to be landed. Could you take a look when you have ...
7 years, 7 months ago (2013-05-07 10:39:13 UTC) #1
bulach
lgtm (but not an owner), thanks!
7 years, 7 months ago (2013-05-07 14:06:00 UTC) #2
willchan no longer on Chromium
lgtm other than the style nit https://codereview.chromium.org/14845011/diff/1/third_party/tcmalloc/chromium/src/base/logging.h File third_party/tcmalloc/chromium/src/base/logging.h (right): https://codereview.chromium.org/14845011/diff/1/third_party/tcmalloc/chromium/src/base/logging.h#newcode214 third_party/tcmalloc/chromium/src/base/logging.h:214: case INFO: Indentation ...
7 years, 7 months ago (2013-05-07 14:45:35 UTC) #3
Dai Mikurube (NOT FULLTIME)
Thanks, bulach and willchan! Updated the patch, and committing... https://codereview.chromium.org/14845011/diff/1/third_party/tcmalloc/chromium/src/base/logging.h File third_party/tcmalloc/chromium/src/base/logging.h (right): https://codereview.chromium.org/14845011/diff/1/third_party/tcmalloc/chromium/src/base/logging.h#newcode214 third_party/tcmalloc/chromium/src/base/logging.h:214: ...
7 years, 7 months ago (2013-05-07 17:10:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14845011/4001
7 years, 7 months ago (2013-05-07 17:10:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125015
7 years, 7 months ago (2013-05-07 17:29:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14845011/4001
7 years, 7 months ago (2013-05-07 17:39:23 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125143
7 years, 7 months ago (2013-05-07 19:47:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14845011/4001
7 years, 7 months ago (2013-05-07 21:38:16 UTC) #9
Dai Mikurube (NOT FULLTIME)
7 years, 7 months ago (2013-05-08 12:05:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r198879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698