Plumb base::Feature field trial association to renderers.

Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077
Committed: https://crrev.com/b2e44d8215dd9d4ed6316c6696b576cf77cb363c
Cr-Commit-Position: refs/heads/master@{#362343}

[Alexei Svitkine (slow), 2015-11-27 18:16:37]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2015-11-27 18:24:25]

Description was changed from

==========
Plumb base::Feature field trial association to renderers.

BUG=...
==========

to

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

BUG=561077
==========

[Alexei Svitkine (slow), 2015-11-30 17:58:23]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2015-11-30 17:58:36]

Patchset #1 (id:40001) has been deleted

[Alexei Svitkine (slow), 2015-11-30 18:00:10]

Patchset #1 (id:60001) has been deleted

[Alexei Svitkine (slow), 2015-11-30 18:39:03]

Patchset #1 (id:80001) has been deleted

[Alexei Svitkine (slow), 2015-11-30 18:39:20]

Description was changed from

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

BUG=561077
==========

to

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077
==========

[Alexei Svitkine (slow), 2015-11-30 18:39:28]

asvitkine@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2015-11-30 18:54:40]

LGTM, thanks.

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc
File base/feature_list.cc (right):

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc#n...
base/feature_list.cc:27: // are used in command-line API functions that require
ASCII) and if there are
Optional nit: s/if/whether helps clarity IMO

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc#n...
base/feature_list.cc:30: bool ValidateFeatureOrFieldTrialName(const std::string&
name) {
nit: Perhaps "IsValidFeatureOrFieldTrialName"?

[Alexei Svitkine (slow), 2015-11-30 19:44:35]

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc
File base/feature_list.cc (right):

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc#n...
base/feature_list.cc:27: // are used in command-line API functions that require
ASCII) and if there are
On 2015/11/30 18:54:40, Ilya Sherman wrote:
> Optional nit: s/if/whether helps clarity IMO

Done.

https://codereview.chromium.org/1484483002/diff/100001/base/feature_list.cc#n...
base/feature_list.cc:30: bool ValidateFeatureOrFieldTrialName(const std::string&
name) {
On 2015/11/30 18:54:40, Ilya Sherman wrote:
> nit: Perhaps "IsValidFeatureOrFieldTrialName"?

Done.

[Alexei Svitkine (slow), 2015-12-01 03:28:48]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-12-01 03:28:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1484483002/#ps120001
(title: "Address nits.")

[commit-bot: I haz the power, 2015-12-01 03:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484483002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484483002/120001

[commit-bot: I haz the power, 2015-12-01 04:10:34]

Description was changed from

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077
==========

to

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077
==========

[commit-bot: I haz the power, 2015-12-01 04:10:35]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2015-12-01 04:11:12]

Description was changed from

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077
==========

to

==========
Plumb base::Feature field trial association to renderers.

This CL makes the FeatureList command-line initialization code
support an optional FieldTrial name for each feature that will
be associated with the feature override when specified. Also
changes the code that generates this command-line to also
include this name.

With this change, renderers will be launched with this
association specified on the command-line, so that querying
a Feature in the renderer only that's associated with a field
trial will result in that trial being activated (and sync'd with
the browser process by the existing mechanism).

Depends on:
https://codereview.chromium.org/1471693007

BUG=561077

Committed: https://crrev.com/b2e44d8215dd9d4ed6316c6696b576cf77cb363c
Cr-Commit-Position: refs/heads/master@{#362343}
==========

[commit-bot: I haz the power, 2015-12-01 04:11:13]

Patchset 2 (id:??) landed as
https://crrev.com/b2e44d8215dd9d4ed6316c6696b576cf77cb363c
Cr-Commit-Position: refs/heads/master@{#362343}