ui/gl/gl_utils.h - Issue 1484473003: gl, ozone: enable GLImageBindTest unittests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/gl_utils.h

Issue 1484473003: gl, ozone: enable GLImageBindTest unittests Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fix for win and mac, but cros need crrev.com/1208603002 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GL_GL_UTILS_H_

	6 #define UI_GL_GL_UTILS_H_

	7

	8 #include "base/macros.h"

	9 #include "ui/gfx/buffer_types.h"

	10 #include "ui/gl/gl_export.h"

	11

	12 typedef unsigned int GLenum;

	13

	14 namespace gl {

	15

	16 GL_EXPORT GLenum GetTextureFormatFrom(gfx::BufferFormat format);
	reveman 2016/01/13 15:50:09 Not sure we need this change as part of this patch Not sure we need this change as part of this patch but it we do then I'd rather see the TextureFormat function in GLImageMemory moved to the GLImage class. dshwang 2016/01/13 17:07:42 Done. we need, because both GLImageMemory and unit Show quoted text On 2016/01/13 15:50:09, reveman wrote: > Not sure we need this change as part of this patch but it we do then I'd rather > see the TextureFormat function in GLImageMemory moved to the GLImage class. Done. we need, because both GLImageMemory and unittests need it. Unlik GLImageSharedMemoryTestDelegate and GLImageRefCountedMemoryTestDelegate, GLImageOzoneNativePixmapTestDelegate cannot use GLImageMemory::GetInternalFormatForTesting because GLImageOzoneNativePixmap doesn't inherit GLImageMemory.
	17

	18 } // namespace gl

	19

	20 #endif // UI_GL_GL_UTILS_H_

OLD	NEW