Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1484463003: Drop [LegacyInterfaceTypeChecking] for the Presentation API (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for the Presentation API The change to the send() methods are unobservable, because the added TypeError exceptions in the generated code are unreachable, as type testing is first used to pick which send() to dispatch to. The change to defaultRequest is observable, in that something like `presentation.defaultRequest = {}` will now throw TypeError instead of setting defaultRequest to null. Since this is a very new API, this is very unlikely to be a problem. BUG=561338 Committed: https://crrev.com/cadd9dedf9d9f3b0a88a9a29b32c3674c36d8823 Cr-Commit-Position: refs/heads/master@{#363464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/presentation/Presentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
philipj_slow
PTAL. I'm on the fence about adding a test for defaultRequest. Nobody will have any ...
5 years ago (2015-12-04 21:47:37 UTC) #3
mlamouri (slow - plz ping)
lgtm
5 years ago (2015-12-07 10:20:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484463003/1
5 years ago (2015-12-07 10:20:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 13:04:05 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-07 13:05:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cadd9dedf9d9f3b0a88a9a29b32c3674c36d8823
Cr-Commit-Position: refs/heads/master@{#363464}

Powered by Google App Engine
This is Rietveld 408576698