Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: media/cast/sender/frame_sender.h

Issue 1484403002: cast: Support for low-latency interactive mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/frame_sender.h
diff --git a/media/cast/sender/frame_sender.h b/media/cast/sender/frame_sender.h
index d3b925e6dcf0e8d74a1dfb7e51cd1343e7a11f6e..5968173b06da88a7676ec01a584639a597dd9811 100644
--- a/media/cast/sender/frame_sender.h
+++ b/media/cast/sender/frame_sender.h
@@ -32,6 +32,7 @@ class FrameSender {
double max_frame_rate,
base::TimeDelta min_playout_delay,
base::TimeDelta max_playout_delay,
+ base::TimeDelta animated_playout_delay,
CongestionControl* congestion_control);
virtual ~FrameSender();
@@ -105,15 +106,24 @@ class FrameSender {
// Returns the number of frames that were sent but not yet acknowledged.
int GetUnacknowledgedFrameCount() const;
- // The total amount of time between a frame's capture/recording on the sender
- // and its playback on the receiver (i.e., shown to a user). This is fixed as
- // a value large enough to give the system sufficient time to encode,
- // transmit/retransmit, receive, decode, and render; given its run-time
- // environment (sender/receiver hardware performance, network conditions,
- // etc.).
+ // Playout delay represents total amount of time between a frame's
+ // capture/recording on the sender and its playback on the receiver
+ // (i.e., shown to a user). This should be a value large enough to
+ // give the system sufficient time to encode, transmit/retransmit,
+ // receive, decode, and render; given its run-time environment
+ // (sender/receiver hardware performance, network conditions,etc.).
+
+ // The |target_playout delay_| is the current delay that is adaptively
miu 2015/12/03 21:26:23 Nice comment! :)
+ // adjusted based on feedback from video capture engine and the congestion
+ // control. In case of interactive content, the target is adjusted to start
+ // at |min_playout_delay_| and in case of animated content, it starts out at
+ // |animated_playout_delay_| and then adaptively adjust based on feedback
+ // from congestion control.
base::TimeDelta target_playout_delay_;
base::TimeDelta min_playout_delay_;
miu 2015/12/03 21:26:23 nit: Looks like min/max/animated_playout_delay_ co
Irfan 2015/12/04 22:45:37 Done.
base::TimeDelta max_playout_delay_;
+ // Starting playout delay for animated content.
+ base::TimeDelta animated_playout_delay_;
// If true, we transmit the target playout delay to the receiver.
bool send_target_playout_delay_;

Powered by Google App Engine
This is Rietveld 408576698