test/cctest/test-strings.cc - Issue 1484393002: [runtime] Adding more detailed error message for Object::GetMethod.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/test-strings.cc

Issue 1484393002: [runtime] Adding more detailed error message for Object::GetMethod. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixing test error strings Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/messages.js » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Redistribution and use in source and binary forms, with or without	2 // Redistribution and use in source and binary forms, with or without

3 // modification, are permitted provided that the following conditions are	3 // modification, are permitted provided that the following conditions are

4 // met:	4 // met:

5 //	5 //

6 // * Redistributions of source code must retain the above copyright	6 // * Redistributions of source code must retain the above copyright

7 // notice, this list of conditions and the following disclaimer.	7 // notice, this list of conditions and the following disclaimer.

8 // * Redistributions in binary form must reproduce the above	8 // * Redistributions in binary form must reproduce the above

9 // copyright notice, this list of conditions and the following	9 // copyright notice, this list of conditions and the following

10 // disclaimer in the documentation and/or other materials provided	10 // disclaimer in the documentation and/or other materials provided

(...skipping 1459 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1470 LocalContext context;	1470 LocalContext context;

1471 Isolate* isolate = CcTest::i_isolate();	1471 Isolate* isolate = CcTest::i_isolate();

1472 HandleScope scope(isolate);	1472 HandleScope scope(isolate);

1473 Handle<String> arg0 = isolate->factory()->NewStringFromAsciiChecked("arg0");	1473 Handle<String> arg0 = isolate->factory()->NewStringFromAsciiChecked("arg0");

1474 Handle<String> arg1 = isolate->factory()->NewStringFromAsciiChecked("arg1");	1474 Handle<String> arg1 = isolate->factory()->NewStringFromAsciiChecked("arg1");

1475 Handle<String> arg2 = isolate->factory()->NewStringFromAsciiChecked("arg2");	1475 Handle<String> arg2 = isolate->factory()->NewStringFromAsciiChecked("arg2");

1476 Handle<String> result =	1476 Handle<String> result =

1477 MessageTemplate::FormatMessage(MessageTemplate::kPropertyNotFunction,	1477 MessageTemplate::FormatMessage(MessageTemplate::kPropertyNotFunction,

1478 arg0, arg1, arg2).ToHandleChecked();	1478 arg0, arg1, arg2).ToHandleChecked();

1479 Handle<String> expected = isolate->factory()->NewStringFromAsciiChecked(	1479 Handle<String> expected = isolate->factory()->NewStringFromAsciiChecked(

1480 "Property 'arg0' of object arg1 is not a function");	1480 "'arg0' returned for property 'arg1' of object 'arg2' is not a function");

1481 CHECK(String::Equals(result, expected));	1481 CHECK(String::Equals(result, expected));

1482 }	1482 }

OLD	NEW