Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/js/collection.js

Issue 1484393002: [runtime] Adding more detailed error message for Object::GetMethod. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixing test error strings Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/js/weak-collection.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 "use strict"; 6 "use strict";
7 7
8 %CheckIsBootstrapping(); 8 %CheckIsBootstrapping();
9 9
10 // ------------------------------------------------------------------- 10 // -------------------------------------------------------------------
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 function SetConstructor(iterable) { 127 function SetConstructor(iterable) {
128 if (IS_UNDEFINED(new.target)) { 128 if (IS_UNDEFINED(new.target)) {
129 throw MakeTypeError(kConstructorNotFunction, "Set"); 129 throw MakeTypeError(kConstructorNotFunction, "Set");
130 } 130 }
131 131
132 %_SetInitialize(this); 132 %_SetInitialize(this);
133 133
134 if (!IS_NULL_OR_UNDEFINED(iterable)) { 134 if (!IS_NULL_OR_UNDEFINED(iterable)) {
135 var adder = this.add; 135 var adder = this.add;
136 if (!IS_CALLABLE(adder)) { 136 if (!IS_CALLABLE(adder)) {
137 throw MakeTypeError(kPropertyNotFunction, 'add', this); 137 throw MakeTypeError(kPropertyNotFunction, adder, 'add', this);
138 } 138 }
139 139
140 for (var value of iterable) { 140 for (var value of iterable) {
141 %_Call(adder, this, value); 141 %_Call(adder, this, value);
142 } 142 }
143 } 143 }
144 } 144 }
145 145
146 146
147 function SetAdd(key) { 147 function SetAdd(key) {
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 function MapConstructor(iterable) { 283 function MapConstructor(iterable) {
284 if (IS_UNDEFINED(new.target)) { 284 if (IS_UNDEFINED(new.target)) {
285 throw MakeTypeError(kConstructorNotFunction, "Map"); 285 throw MakeTypeError(kConstructorNotFunction, "Map");
286 } 286 }
287 287
288 %_MapInitialize(this); 288 %_MapInitialize(this);
289 289
290 if (!IS_NULL_OR_UNDEFINED(iterable)) { 290 if (!IS_NULL_OR_UNDEFINED(iterable)) {
291 var adder = this.set; 291 var adder = this.set;
292 if (!IS_CALLABLE(adder)) { 292 if (!IS_CALLABLE(adder)) {
293 throw MakeTypeError(kPropertyNotFunction, 'set', this); 293 throw MakeTypeError(kPropertyNotFunction, adder, 'set', this);
294 } 294 }
295 295
296 for (var nextItem of iterable) { 296 for (var nextItem of iterable) {
297 if (!IS_SPEC_OBJECT(nextItem)) { 297 if (!IS_SPEC_OBJECT(nextItem)) {
298 throw MakeTypeError(kIteratorValueNotAnObject, nextItem); 298 throw MakeTypeError(kIteratorValueNotAnObject, nextItem);
299 } 299 }
300 %_Call(adder, this, nextItem[0], nextItem[1]); 300 %_Call(adder, this, nextItem[0], nextItem[1]);
301 } 301 }
302 } 302 }
303 } 303 }
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 "set_has", SetHas, 469 "set_has", SetHas,
470 "set_delete", SetDelete, 470 "set_delete", SetDelete,
471 ]); 471 ]);
472 472
473 utils.Export(function(to) { 473 utils.Export(function(to) {
474 to.GetExistingHash = GetExistingHash; 474 to.GetExistingHash = GetExistingHash;
475 to.GetHash = GetHash; 475 to.GetHash = GetHash;
476 }); 476 });
477 477
478 }) 478 })
OLDNEW
« no previous file with comments | « no previous file | src/js/weak-collection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698