Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1484393002: [runtime] Adding more detailed error message for Object::GetMethod. (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Adding more detailed error message for Object::GetMethod. BUG= Committed: https://crrev.com/9cffd0d2cec0ed8cf6624843a4136f13d2a347ef Cr-Commit-Position: refs/heads/master@{#32506}

Patch Set 1 #

Patch Set 2 : fixing test error strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/js/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/js/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484393002/1
5 years ago (2015-12-01 17:36:42 UTC) #2
Camillo Bruni
PTAL
5 years ago (2015-12-01 17:40:01 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10858)
5 years ago (2015-12-01 17:50:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484393002/1
5 years ago (2015-12-02 08:54:27 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10887)
5 years ago (2015-12-02 09:13:58 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484393002/20001
5 years ago (2015-12-02 09:45:10 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 10:22:05 UTC) #14
Igor Sheludko
lgtm
5 years ago (2015-12-02 11:25:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484393002/20001
5 years ago (2015-12-02 12:13:48 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 12:25:08 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-02 12:25:58 UTC) #20
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9cffd0d2cec0ed8cf6624843a4136f13d2a347ef
Cr-Commit-Position: refs/heads/master@{#32506}

Powered by Google App Engine
This is Rietveld 408576698