Use WindowTracker when resizing root window as it may delete other window in unit tests.

Use WindowTracker when resizing root window as it may delete other window in unit tests.

This so far can happen in the test. The CL https://codereview.chromium.org/1483083003/ changes the timing of animation completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org

Committed: https://crrev.com/cabad394cf3cd7cacd97ecc4a4365b651dac69b8
Cr-Commit-Position: refs/heads/master@{#363004}

[oshima, 2015-12-01 20:17:15]

Description was changed from

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org
==========

to

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

This so far can happen in the test. The CL
https://codereview.chromium.org/1483083003/ changes the timing of animation
completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org
==========

[oshima, 2015-12-01 20:17:27]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 20:26:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484383003/1

[oshima, 2015-12-01 20:35:13]

Patchset #2 (id:20001) has been deleted

[sky, 2015-12-02 22:01:04]

https://codereview.chromium.org/1484383003/diff/1/ash/wm/root_window_layout_m...
File ash/wm/root_window_layout_manager.cc (right):

https://codereview.chromium.org/1484383003/diff/1/ash/wm/root_window_layout_m...
ash/wm/root_window_layout_manager.cc:41: while
(grandchildren_tracker.has_windows())
WindowTracker internally uses a set. The old code use the child order in a
vector. This means you're subtley changing the order of the resize, and in a
non-deterministic way. I think we should keep it the way we had it.

[oshima, 2015-12-03 00:31:35]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 00:36:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484383003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484383003/40001

[commit-bot: I haz the power, 2015-12-03 01:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 01:08:58]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-12-03 05:24:34]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 05:24:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484383003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484383003/60001

[oshima, 2015-12-03 05:50:13]

https://codereview.chromium.org/1484383003/diff/1/ash/wm/root_window_layout_m...
File ash/wm/root_window_layout_manager.cc (right):

https://codereview.chromium.org/1484383003/diff/1/ash/wm/root_window_layout_m...
ash/wm/root_window_layout_manager.cc:41: while
(grandchildren_tracker.has_windows())
On 2015/12/02 22:01:04, sky wrote:
> WindowTracker internally uses a set. The old code use the child order in a
> vector. This means you're subtley changing the order of the resize, and in a
> non-deterministic way. I think we should keep it the way we had it.

Good point. I changed WT to use vector instead.

[commit-bot: I haz the power, 2015-12-03 06:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 06:06:13]

Dry run: This issue passed the CQ dry run.

[sky, 2015-12-03 16:57:05]

LGTM

[oshima, 2015-12-03 17:29:41]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-12-03 17:30:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1484383003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1484383003/60001

[commit-bot: I haz the power, 2015-12-03 17:38:28]

Description was changed from

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

This so far can happen in the test. The CL
https://codereview.chromium.org/1483083003/ changes the timing of animation
completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org
==========

to

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

This so far can happen in the test. The CL
https://codereview.chromium.org/1483083003/ changes the timing of animation
completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2015-12-03 17:38:28]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-12-03 17:39:33]

Description was changed from

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

This so far can happen in the test. The CL
https://codereview.chromium.org/1483083003/ changes the timing of animation
completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org
==========

to

==========
Use WindowTracker when resizing root window as it may delete other window in
unit tests.

This so far can happen in the test. The CL
https://codereview.chromium.org/1483083003/ changes the timing of animation
completion, which led to this state.

BUG=None
TEST=RootWindowLayoutManagerTest.DeleteChildDuringResize
R=sky@chromium.org

Committed: https://crrev.com/cabad394cf3cd7cacd97ecc4a4365b651dac69b8
Cr-Commit-Position: refs/heads/master@{#363004}
==========

[commit-bot: I haz the power, 2015-12-03 17:39:34]

Patchset 3 (id:??) landed as
https://crrev.com/cabad394cf3cd7cacd97ecc4a4365b651dac69b8
Cr-Commit-Position: refs/heads/master@{#363004}

[huangs, 2016-02-12 01:23:47]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1689873005/ by huangs@chromium.org.

The reason for reverting is: Not reverting: Experimenting with tracing cause of
http://crrev.com/583233..