Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1484373002: Add an SkPath conic conversion utility. (Closed)

Created:
5 years ago by f(malita)
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add an SkPath conic conversion utility. Expose SkConic::chopIntoQuadsPOW2() as SkPath::ConvertConicToQuads(). BUG=chromium:315277 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/aa0df4e98d39cf0691fbaf0766c9f5f7ec72177f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M include/core/SkPath.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
f(malita)
5 years ago (2015-12-01 16:50:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484373002/1
5 years ago (2015-12-01 16:51:11 UTC) #3
reed1
lgtm do you think 3 points is a better api than pts[3]?
5 years ago (2015-12-01 16:56:38 UTC) #4
f(malita)
On 2015/12/01 16:56:38, reed1 wrote: > do you think 3 points is a better api ...
5 years ago (2015-12-01 17:07:00 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 17:09:31 UTC) #7
reed1
On 2015/12/01 17:07:00, f(malita) wrote: > On 2015/12/01 16:56:38, reed1 wrote: > > do you ...
5 years ago (2015-12-01 17:10:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484373002/1
5 years ago (2015-12-01 17:12:44 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 17:13:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa0df4e98d39cf0691fbaf0766c9f5f7ec72177f

Powered by Google App Engine
This is Rietveld 408576698