Derive default for ar_host from ar.

Derive default for ar_host from ar.

Patch from herhut@google.com.

R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/6fb8bd829f0ca8fd432fd85ede788b6881c4f09f

[herhut, 2015-12-01 12:16:23]

Description was changed from

==========
Derive default for ar_host from ar.

BUG=
==========

to

==========
Derive default for ar_host from ar.

BUG=
==========

[herhut, 2015-12-01 12:16:23]

herhut@google.com changed reviewers:
+ scottmg@chromium.org

[herhut, 2015-12-01 12:19:32]

This change should have no effect on non-windows platforms.

The default for ar_host in generated ninja files is hard-coded to 'ar'. However,
on Windows this is not very helpful. By falling back to the default for ar, it
will be LINK.EXE on Windows and remain ar otherwise.

I am porting fletch (https://github.com/dart-lang/fletch) to Windows and this
change would make that a lot easier.

[scottmg, 2015-12-01 17:27:44]

This seems fine, but please add a test that uses $ar somehow so it doesn't
regress.

On 2015/12/01 12:19:32, herhut wrote:
> This change should have no effect on non-windows platforms.
> 
> The default for ar_host in generated ninja files is hard-coded to 'ar'.
However,
> on Windows this is not very helpful. By falling back to the default for ar, it
> will be LINK.EXE on Windows and remain ar otherwise.

You mean lib.exe, right?

> 
> I am porting fletch (https://github.com/dart-lang/fletch) to Windows and this
> change would make that a lot easier.

[herhut, 2015-12-02 14:26:36]

Patchset #2 (id:20001) has been deleted

[herhut, 2015-12-02 14:28:22]

On 2015/12/01 17:27:44, scottmg wrote:
> This seems fine, but please add a test that uses $ar somehow so it doesn't
> regress.

Done, PTAL.

> On 2015/12/01 12:19:32, herhut wrote:
> > This change should have no effect on non-windows platforms.
> > 
> > The default for ar_host in generated ninja files is hard-coded to 'ar'.
> However,
> > on Windows this is not very helpful. By falling back to the default for ar,
it
> > will be LINK.EXE on Windows and remain ar otherwise.
> 
> You mean lib.exe, right?

Yes, indeed. Sorry.

> > 
> > I am porting fletch (https://github.com/dart-lang/fletch) to Windows and
this
> > change would make that a lot easier.

[scottmg, 2015-12-02 15:27:58]

lgtm

[scottmg, 2015-12-02 15:28:49]

Description was changed from

==========
Derive default for ar_host from ar.

BUG=
==========

to

==========
Derive default for ar_host from ar.

Patch from herhut@google.com.
==========

[scottmg, 2015-12-02 17:39:43]

Looks like test\make_global_settings\ar\gyptest-make_global_settings_ar.py needs
to be modified.

[herhut, 2015-12-03 15:25:35]

On 2015/12/02 17:39:43, scottmg wrote:
> Looks like test\make_global_settings\ar\gyptest-make_global_settings_ar.py
needs
> to be modified.

Done that, the windows and mac bot are green now, the linux one seems offline.

[scottmg, 2015-12-03 18:16:23]

lgtm

[scottmg, 2015-12-03 18:18:09]

Description was changed from

==========
Derive default for ar_host from ar.

Patch from herhut@google.com.
==========

to

==========
Derive default for ar_host from ar.

Patch from herhut@google.com.

R=scottmg@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/6fb8bd829f0ca8fd432fd85ede78...
==========

[scottmg, 2015-12-03 18:18:10]

Committed patchset #3 (id:60001) manually as
6fb8bd829f0ca8fd432fd85ede788b6881c4f09f (presubmit successful).

[scottmg, 2015-12-03 18:18:32]

(I changed the copyright from Chromium to Google on
test/win/gyptest-crosscompile-ar.py.)