Issue 148433007: <webview>: Fix text selection features in mac.

Issue 148433007: <webview>: Fix text selection features in mac. (Closed)

Created:
6 years, 10 months ago by lazyboy

Modified:
6 years, 10 months ago

Reviewers:
Fady Samuel, kochi, nasko, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

<webview>: Fix text selection features in mac. We still need to pass RWHVGuest::SelectionChanged() call to platform_view_. This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod). Wrote a browser_test to catch the regression. BUG=331722 Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247589

Patch Set 1 #

Patch Set 2 : reup (chunk mismatch). #

Patch Set 3 : fix copy(c) year. #

Patch Set 4 : Rename ContextMenuNotificationObserver in bookmark_bar_view_test.* to not conflict. #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -29 lines)			Patch
M	chrome/browser/apps/web_view_interactive_browsertest.cc	View		4 chunks	+34 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View	1 2 3	17 chunks	+19 lines, -18 lines	1 comment	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/text_selection/embedder.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/platform_apps/web_view/text_selection/embedder.js	View		1 chunk	+55 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/web_view/text_selection/guest.html	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/web_view/text_selection/manifest.json	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/web_view/text_selection/test.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/frame_host/render_widget_host_view_guest.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/frame_host/render_widget_host_view_guest.cc	View	1 2 3	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

lazyboy

kochi@ for RenderWidgetHostViewGuest::SelectionChanged(), I believe we don't need to pass the notification to the embedder ...

6 years, 10 months ago (2014-01-28 02:51:02 UTC) #1

kochi

RWHVG LGTM Looks like the change I made for https://codereview.chromium.org/103403006/#msg12 was wrong. Thanks for working ...

6 years, 10 months ago (2014-01-28 08:16:10 UTC) #2

lazyboy

+sky for changes in bookmark_bar_view_test.cc https://chromiumcodereview.appspot.com/148433007/diff/60001/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right): https://chromiumcodereview.appspot.com/148433007/diff/60001/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc#newcode435 chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:435: class BookmarkContextMenuNotificationObserver This rename ...

6 years, 10 months ago (2014-01-28 21:02:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/148433007/60001

6 years, 10 months ago (2014-01-28 23:37:39 UTC) #8

gavinp

6 years, 10 months ago (2014-01-29 18:22:34 UTC) #10

Message was sent while issue was closed.

On 2014/01/29 02:12:43, I haz the power (commit-bot) wrote:
> Change committed as 247589

I reverted this in r247722. It was suspected of causing flakes in
WithoutThreadedCompositor/WebViewCaptureTest.Shim_ScreenshotCapture , see
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5692
and http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/928

Very strange that it only showed up in blink builders and not Chromium. We'll
watch the tree and report back here if it still happens.

Expand Messages | Collapse Messages