Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 14843020: Unify deoptimizer for JavaScript frames. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Unify deoptimizer for JavaScript frames. This unifies the translation of an optimized frame to a full JavaScript frame. Only the frame's context and fp register as well as alignment padding are different on each architecture and can be factored out. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -550 lines) Patch
M src/arm/deoptimizer-arm.cc View 2 chunks +6 lines, -182 lines 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M src/frames.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +14 lines, -191 lines 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 2 chunks +6 lines, -177 lines 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 7 months ago (2013-05-16 16:42:01 UTC) #1
Sven Panne
LGTM. Very nice cleanup!
7 years, 7 months ago (2013-05-17 06:59:25 UTC) #2
Michael Starzinger
7 years, 7 months ago (2013-05-17 08:28:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698