Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 14843017: [Android] Support building standalone APK in component build (Closed)

Created:
7 years, 7 months ago by cjhopman
Modified:
7 years, 6 months ago
Reviewers:
shashi, Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Support building standalone APK in component build Many people's workflows assume that they can install the APK created in out/Debug/apks. With the component build that APK is actually an "incomplete" APK that cannot be manually installed (or rather causes obscure errors when manually installed). This change does two things. First, it moves the "incomplete" APK output to out/Debug/<package_name>/<ApkName>.apk. This should prevent accidental installs of the "incomplete" APK. Second, it introduces an option (create_standalone_apk) that when doing a component build, if set, will merge the shared libraries into the "incomplete" APK to create a standalone APK. This standalone APK will be created in out/Debug/apks/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207516 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208529

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address nit #

Patch Set 4 : Fix test apks #

Patch Set 5 : #

Patch Set 6 : Rebase #

Patch Set 7 : #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -37 lines) Patch
M build/android/developer_recommended_flags.gypi View 1 chunk +7 lines, -2 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 1 2 3 4 5 6 2 chunks +7 lines, -7 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 3 4 9 chunks +56 lines, -28 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
cjhopman
7 years, 7 months ago (2013-05-14 22:25:27 UTC) #1
cjhopman
7 years, 6 months ago (2013-06-15 00:53:11 UTC) #2
shashi
lgtm, wait for Yaron, he may know this code better. https://chromiumcodereview.appspot.com/14843017/diff/1/build/android/gyp/create_standalone_apk.py File build/android/gyp/create_standalone_apk.py (right): https://chromiumcodereview.appspot.com/14843017/diff/1/build/android/gyp/create_standalone_apk.py#newcode32 ...
7 years, 6 months ago (2013-06-18 18:10:48 UTC) #3
Yaron
lgtm https://chromiumcodereview.appspot.com/14843017/diff/1/build/android/developer_recommended_flags.gypi File build/android/developer_recommended_flags.gypi (right): https://chromiumcodereview.appspot.com/14843017/diff/1/build/android/developer_recommended_flags.gypi#newcode48 build/android/developer_recommended_flags.gypi:48: 'create_standalone_apk%': 1, Kinda redundant if you have it ...
7 years, 6 months ago (2013-06-19 17:33:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/15001
7 years, 6 months ago (2013-06-20 01:42:32 UTC) #5
commit-bot: I haz the power
Change committed as 207345
7 years, 6 months ago (2013-06-20 07:58:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/32001
7 years, 6 months ago (2013-06-20 15:46:04 UTC) #7
commit-bot: I haz the power
Change committed as 207516
7 years, 6 months ago (2013-06-20 19:51:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/52001
7 years, 6 months ago (2013-06-21 18:20:47 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-21 20:03:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/52001
7 years, 6 months ago (2013-06-24 18:04:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/73002
7 years, 6 months ago (2013-06-25 01:10:16 UTC) #12
commit-bot: I haz the power
Failed to apply patch for build/android/gyp/create_standalone_apk.py: File exist but was about to be overwriten Patch: ...
7 years, 6 months ago (2013-06-25 04:00:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14843017/97001
7 years, 6 months ago (2013-06-25 16:44:09 UTC) #14
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 18:42:08 UTC) #15
Message was sent while issue was closed.
Change committed as 208529

Powered by Google App Engine
This is Rietveld 408576698