Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 14843010: Suppressed new&failing tests from Selenium head, added to third_party in a separate patch. (Closed)

Created:
7 years, 7 months ago by klm
Modified:
7 years, 6 months ago
Reviewers:
kkania
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Suppressed new&failing tests from Selenium head, added to third_party in a separate patch. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199802 R=kkania@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/test/chromedriver/test_expectations View 4 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
klm
Two tests fail the same way before&after the update, with Chrome Canary 29: Ran 660 ...
7 years, 7 months ago (2013-05-10 14:26:19 UTC) #1
klm
Oh and I added the diff URLs showing where the tests were added -- just ...
7 years, 7 months ago (2013-05-10 14:29:25 UTC) #2
klm
For reference, the test update patch is https://chromiumcodereview.appspot.com/15029007/.
7 years, 7 months ago (2013-05-10 19:34:59 UTC) #3
kkania
lgtm
7 years, 7 months ago (2013-05-13 19:19:33 UTC) #4
klm
On 2013/05/13 19:19:33, kkania wrote: > lgtm Should I commit or wait to understand how ...
7 years, 7 months ago (2013-05-13 19:31:31 UTC) #5
kkania
On 2013/05/13 19:31:31, klm wrote: > On 2013/05/13 19:19:33, kkania wrote: > > lgtm > ...
7 years, 7 months ago (2013-05-13 19:43:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klm@google.com/14843010/1
7 years, 7 months ago (2013-05-13 19:43:53 UTC) #7
commit-bot: I haz the power
Change committed as 199802
7 years, 7 months ago (2013-05-13 19:50:56 UTC) #8
kkania
7 years, 6 months ago (2013-06-10 18:53:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r205255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698