Issue 1484273002: Require jsInteropObject type to be resolved before we use it in native behaviors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1484273002: Require jsInteropObject type to be resolved before we use it in native behaviors (Closed)

Created:
5 years ago by Siggi Cherem (dart-lang)

Modified:
5 years ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Require jsInteropObject type to be resolved before we use it in native behaviors This fixes a failing interop test in the bots. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/b837d63d47aed38ceae39b78ba4d04048475d0e5

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/native/behavior.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	tests/html/js_dart_to_string_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

5 years ago (2015-12-01 01:37:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
b837d63d47aed38ceae39b78ba4d04048475d0e5 (presubmit successful).