Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/codegen/expect/closure.js

Issue 1484263002: Use destructuring assignments for named parameters (#180) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Destructure function params directly (no more opts in most cases) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/js/template.dart ('K') | « lib/src/js/template.dart ('k') | test/codegen/expect/collection/algorithms.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/expect/closure.js
diff --git a/test/codegen/expect/closure.js b/test/codegen/expect/closure.js
index d89bed7ac7a025cdadd20ccab9df97628d6a2645..384373994d543b7e987d9470b3bf0fb08c337aa8 100644
--- a/test/codegen/expect/closure.js
+++ b/test/codegen/expect/closure.js
@@ -65,10 +65,7 @@ dart_library.library('closure', null, /* Imports */[
* @param {?} a
* @param {{b: (?|undefined), c: (?|undefined)}=} opts
*/
- static named_params(a, opts) {
- let b = opts && 'b' in opts ? opts.b : null;
- let c = opts && 'c' in opts ? opts.c : null;
- }
+ static named_params(a, {b = null, c = null} = {}) {}
nullary_method() {}
/**
* @param {function(?, ?=):?number} f
« lib/src/js/template.dart ('K') | « lib/src/js/template.dart ('k') | test/codegen/expect/collection/algorithms.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698