lib/src/js/precedence.dart - Issue 1484263002: Use destructuring assignments for named parameters (#180)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/src/js/precedence.dart

Issue 1484263002: Use destructuring assignments for named parameters (#180) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Destructure function params directly (no more opts in most cases) Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« lib/src/js/nodes.dart ('K') | « lib/src/js/nodes.dart ('k') | lib/src/js/printer.dart » ('j') | lib/src/js/template.dart » ('J')

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library precedence;	5 library precedence;

6	6

7 const EXPRESSION = 0;	7 const EXPRESSION = 0;

8 const SPREAD = EXPRESSION + 1;	8 const SPREAD = EXPRESSION + 1;

9 const YIELD = SPREAD + 1;	9 const YIELD = SPREAD + 1;

10	10

(...skipping 16 matching lines...) Expand all Loading...
27 const RELATIONAL = EQUALITY + 1;	27 const RELATIONAL = EQUALITY + 1;

28 const SHIFT = RELATIONAL + 1;	28 const SHIFT = RELATIONAL + 1;

29 const ADDITIVE = SHIFT + 1;	29 const ADDITIVE = SHIFT + 1;

30 const MULTIPLICATIVE = ADDITIVE + 1;	30 const MULTIPLICATIVE = ADDITIVE + 1;

31 const UNARY = MULTIPLICATIVE + 1;	31 const UNARY = MULTIPLICATIVE + 1;

32 const LEFT_HAND_SIDE = UNARY + 1;	32 const LEFT_HAND_SIDE = UNARY + 1;

33 const CALL = LEFT_HAND_SIDE;	33 const CALL = LEFT_HAND_SIDE;

34 // We always emit `new` with parenthesis, so it uses ACCESS as its precedence.	34 // We always emit `new` with parenthesis, so it uses ACCESS as its precedence.

35 const ACCESS = CALL + 1;	35 const ACCESS = CALL + 1;

36 const PRIMARY = ACCESS + 1;	36 const PRIMARY = ACCESS + 1;

	37 const DESTRUCTURING = PRIMARY + 1;
	Jennifer Messerly 2015/12/01 02:10:27 hmm, not sure this really makes sense as a precede hmm, not sure this really makes sense as a precedence level. Did it solve an actual problem with printing or just added because most existing nodes have it? My gut sense is it doesn't really make sense here, as it's not really an expression, but a form of assignment/variable initialization. Since you'd need something to fill in, I'd just leave the getters in the AST nodes as returning PRIMARY. That will ensure no parens get added ever. & I'd put a comment to that effect. ochafik 2015/12/02 20:05:46 Done. Show quoted text On 2015/12/01 02:10:27, John Messerly wrote: > hmm, not sure this really makes sense as a precedence level. Did it solve an > actual problem with printing or just added because most existing nodes have it? > > My gut sense is it doesn't really make sense here, as it's not really an > expression, but a form of assignment/variable initialization. > > Since you'd need something to fill in, I'd just leave the getters in the AST > nodes as returning PRIMARY. That will ensure no parens get added ever. & I'd put > a comment to that effect. Done.
OLD	NEW