Use destructuring assignments for named parameters (#180)

lib/runtime/dart/core.js

 dart_library.library('dart/core', null, /* Imports */[
   "dart/_runtime"
 ], /* Lazy imports */[
   'dart/_js_helper',
   'dart/_internal',
   'dart/collection',
   'dart/_interceptors',
   'dart/convert'
 ], function(exports, dart, _js_helper, _internal, collection, _interceptors, convert) {
   'use strict';
@@ skipping 55 matching lines @@
     }
   }
   dart.setSignature(_Proxy, {
     constructors: () => ({_Proxy: [_Proxy, []]})
   });
   let proxy = dart.const(new _Proxy());
   dart.defineExtensionNames([
     'toString'
   ]);
   class bool extends Object {
-    static fromEnvironment(name, opts) {
-      let defaultValue = opts && 'defaultValue' in opts ? opts.defaultValue : false;
+    static fromEnvironment(name, {defaultValue = false} = {}) {
       dart.throw(new UnsupportedError('bool.fromEnvironment can only be used as a const constructor'));
     }
     toString() {
       return this ? "true" : "false";
     }
   }
   dart.setSignature(bool, {
     constructors: () => ({fromEnvironment: [bool, [String], {defaultValue: bool}]})
   });
   let Comparator$ = dart.generic(function(T) {
@@ skipping 92 matching lines @@
           dart.throw(new FormatException("Time out of range", formattedString));
         }
         if (dart.notNull(addOneMillisecond)) {
           millisecondsSinceEpoch = dart.notNull(millisecondsSinceEpoch) + 1;
         }
         return new DateTime.fromMillisecondsSinceEpoch(millisecondsSinceEpoch, {isUtc: isUtc});
       } else {
         dart.throw(new FormatException("Invalid date format", formattedString));
       }
     }
-    fromMillisecondsSinceEpoch(millisecondsSinceEpoch, opts) {
-      let isUtc = opts && 'isUtc' in opts ? opts.isUtc : false;
+    fromMillisecondsSinceEpoch(millisecondsSinceEpoch, {isUtc = false} = {}) {
       this.millisecondsSinceEpoch = millisecondsSinceEpoch;
       this.isUtc = isUtc;
       if (dart.notNull(millisecondsSinceEpoch[dartx.abs]()) > dart.notNull(DateTime._MAX_MILLISECONDS_SINCE_EPOCH)) {
         dart.throw(new ArgumentError(millisecondsSinceEpoch));
       }
       if (isUtc == null)
         dart.throw(new ArgumentError(isUtc));
     }
     ['=='](other) {
       if (!dart.is(other, DateTime))
@@ skipping 250 matching lines @@
     statics: () => ({parse: [double, [String], [dart.functionType(double, [String])]]}),
     names: ['parse']
   });
   double.NAN = 0.0 / 0.0;
   double.INFINITY = 1.0 / 0.0;
   double.NEGATIVE_INFINITY = -dart.notNull(double.INFINITY);
   double.MIN_POSITIVE = 5e-324;
   double.MAX_FINITE = 1.7976931348623157e+308;
   let _duration = dart.JsSymbol('_duration');
   class Duration extends Object {
-    Duration(opts) {
-      let days = opts && 'days' in opts ? opts.days : 0;
-      let hours = opts && 'hours' in opts ? opts.hours : 0;
-      let minutes = opts && 'minutes' in opts ? opts.minutes : 0;
-      let seconds = opts && 'seconds' in opts ? opts.seconds : 0;
-      let milliseconds = opts && 'milliseconds' in opts ? opts.milliseconds : 0;
-      let microseconds = opts && 'microseconds' in opts ? opts.microseconds : 0;
+    Duration({days = 0, hours = 0, minutes = 0, seconds = 0, milliseconds = 0, microseconds = 0} = {}) {
       this._microseconds(dart.notNull(days) * dart.notNull(Duration.MICROSECONDS_PER_DAY) + dart.notNull(hours) * dart.notNull(Duration.MICROSECONDS_PER_HOUR) + dart.notNull(minutes) * dart.notNull(Duration.MICROSECONDS_PER_MINUTE) + dart.notNull(seconds) * dart.notNull(Duration.MICROSECONDS_PER_SECOND) + dart.notNull(milliseconds) * dart.notNull(Duration.MICROSECONDS_PER_MILLISECOND) + dart.notNull(microseconds));
     }
     _microseconds(duration) {
       this[_duration] = duration;
     }
     ['+'](other) {
       return new Duration._microseconds(dart.notNull(this[_duration]) + dart.notNull(other[_duration]));
     }
     ['-'](other) {
       return new Duration._microseconds(dart.notNull(this[_duration]) - dart.notNull(other[_duration]));
@@ skipping 752 matching lines @@
   });
   function identical(a, b) {
     return _js_helper.Primitives.identicalImplementation(a, b);
   }
   dart.fn(identical, bool, [Object, Object]);
   function identityHashCode(object) {
     return _js_helper.objectHashCode(object);
   }
   dart.fn(identityHashCode, () => dart.definiteFunctionType(int, [Object]));
   class int extends num {
-    static fromEnvironment(name, opts) {
-      let defaultValue = opts && 'defaultValue' in opts ? opts.defaultValue : null;
+    static fromEnvironment(name, {defaultValue = null} = {}) {
       dart.throw(new UnsupportedError('int.fromEnvironment can only be used as a const constructor'));
     }
-    static parse(source, opts) {
-      let radix = opts && 'radix' in opts ? opts.radix : null;
-      let onError = opts && 'onError' in opts ? opts.onError : null;
+    static parse(source, {radix = null, onError = null} = {}) {
       return _js_helper.Primitives.parseInt(source, radix, onError);
     }
   }
   dart.setSignature(int, {
     constructors: () => ({fromEnvironment: [int, [String], {defaultValue: int}]}),
     statics: () => ({parse: [int, [String], {radix: int, onError: dart.functionType(int, [String])}]}),
     names: ['parse']
   });
   class Invocation extends Object {
     get isAccessor() {
@@ skipping 164 matching lines @@
       }
       static filled(length, fill) {
         let result = List$(E).new(length);
         if (length != 0 && fill != null) {
           for (let i = 0; dart.notNull(i) < dart.notNull(result[dartx.length]); i = dart.notNull(i) + 1) {
             result[dartx.set](i, fill);
           }
         }
         return result;
       }
-      static from(elements, opts) {
-        let growable = opts && 'growable' in opts ? opts.growable : true;
+      static from(elements, {growable = true} = {}) {
         let list = List$(E).new();
         for (let e of elements) {
           list[dartx.add](dart.as(e, E));
         }
         if (dart.notNull(growable))
           return list;
         return dart.as(_internal.makeListFixedLength(list), List$(E));
       }
-      static generate(length, generator, opts) {
-        let growable = opts && 'growable' in opts ? opts.growable : true;
+      static generate(length, generator, {growable = true} = {}) {
         let result = null;
         if (dart.notNull(growable)) {
           result = dart.list([], E);
           result[dartx.length] = length;
         } else {
           result = List$(E).new(length);
         }
         for (let i = 0; dart.notNull(i) < dart.notNull(length); i = dart.notNull(i) + 1) {
           result[dartx.set](i, generator(i));
         }
@@ skipping 62 matching lines @@
     let line = `${object}`;
     if (_internal.printToZone == null) {
       _internal.printToConsole(line);
     } else {
       dart.dcall(_internal.printToZone, line);
     }
   }
   dart.fn(print, dart.void, [Object]);
   class Match extends Object {}
   class RegExp extends Object {
-    static new(source, opts) {
-      let multiLine = opts && 'multiLine' in opts ? opts.multiLine : false;
-      let caseSensitive = opts && 'caseSensitive' in opts ? opts.caseSensitive : true;
+    static new(source, {multiLine = false, caseSensitive = true} = {}) {
       return new _js_helper.JSSyntaxRegExp(source, {multiLine: multiLine, caseSensitive: caseSensitive});
     }
   }
   RegExp[dart.implements] = () => [Pattern];
   dart.setSignature(RegExp, {
     constructors: () => ({new: [RegExp, [String], {multiLine: bool, caseSensitive: bool}]})
   });
   let Set$ = dart.generic(function(E) {
     class Set extends collection.IterableBase$(E) {
       static new() {
@@ skipping 116 matching lines @@
         dart.throw(new RangeError.range(end, start, len));
       }
       if (dart.notNull(start) > 0 || dart.notNull(end) < dart.notNull(len)) {
         list = list[dartx.sublist](start, end);
       }
       return _js_helper.Primitives.stringFromCharCodes(list);
     }
     static fromCharCode(charCode) {
       return _js_helper.Primitives.stringFromCharCode(charCode);
     }
-    static fromEnvironment(name, opts) {
-      let defaultValue = opts && 'defaultValue' in opts ? opts.defaultValue : null;
+    static fromEnvironment(name, {defaultValue = null} = {}) {
       dart.throw(new UnsupportedError('String.fromEnvironment can only be used as a const constructor'));
     }
     static _stringFromIterable(charCodes, start, end) {
       if (dart.notNull(start) < 0)
         dart.throw(new RangeError.range(start, 0, charCodes[dartx.length]));
       if (end != null && dart.notNull(end) < dart.notNull(start)) {
         dart.throw(new RangeError.range(end, start, charCodes[dartx.length]));
       }
       let it = charCodes[dartx.iterator];
       for (let i = 0; dart.notNull(i) < dart.notNull(start); i = dart.notNull(i) + 1) {
@@ skipping 483 matching lines @@
       this.scheme = scheme;
       this[_userInfo] = userInfo;
       this[_host] = host;
       this[_port] = port;
       this[_path] = path;
       this[_query] = query;
       this[_fragment] = fragment;
       this[_pathSegments] = null;
       this[_queryParameters] = null;
     }
-    static new(opts) {
-      let scheme = opts && 'scheme' in opts ? opts.scheme : "";
-      let userInfo = opts && 'userInfo' in opts ? opts.userInfo : "";
-      let host = opts && 'host' in opts ? opts.host : null;
-      let port = opts && 'port' in opts ? opts.port : null;
-      let path = opts && 'path' in opts ? opts.path : null;
-      let pathSegments = opts && 'pathSegments' in opts ? opts.pathSegments : null;
-      let query = opts && 'query' in opts ? opts.query : null;
-      let queryParameters = opts && 'queryParameters' in opts ? opts.queryParameters : null;
-      let fragment = opts && 'fragment' in opts ? opts.fragment : null;
+    static new({scheme = "", userInfo = "", host = null, port = null, path = null, pathSegments = null, query = null, queryParameters = null, fragment = null} = {}) {
       scheme = Uri._makeScheme(scheme, Uri._stringOrNullLength(scheme));
       userInfo = Uri._makeUserInfo(userInfo, 0, Uri._stringOrNullLength(userInfo));
       host = Uri._makeHost(host, 0, Uri._stringOrNullLength(host), false);
       if (query == "")
         query = null;
       query = Uri._makeQuery(query, 0, Uri._stringOrNullLength(query), queryParameters);
       fragment = Uri._makeFragment(fragment, 0, Uri._stringOrNullLength(fragment));
       port = Uri._makePort(port, scheme);
       let isFile = scheme == "file";
       if (host == null && (dart.notNull(userInfo[dartx.isNotEmpty]) || port != null || dart.notNull(isFile))) {
@@ skipping 49 matching lines @@
             let portString = authority[dartx.substring](dart.notNull(hostEnd) + 1);
             if (dart.notNull(portString[dartx.isNotEmpty]))
               port = int.parse(portString);
             break;
           }
         }
         host = authority[dartx.substring](hostStart, hostEnd);
       }
       return Uri.new({scheme: scheme, userInfo: userInfo, host: dart.as(host, String), port: dart.as(port, int), pathSegments: unencodedPath[dartx.split]("/"), queryParameters: queryParameters});
     }
-    static file(path, opts) {
-      let windows = opts && 'windows' in opts ? opts.windows : null;
+    static file(path, {windows = null} = {}) {
       windows = windows == null ? Uri._isWindows : windows;
       return dart.notNull(windows) ? dart.as(Uri._makeWindowsFileUrl(path), Uri) : dart.as(Uri._makeFileUri(path), Uri);
     }
     static get base() {
       let uri = _js_helper.Primitives.currentUri();
       if (uri != null)
         return Uri.parse(uri);
       dart.throw(new UnsupportedError("'Uri.base' is not supported"));
     }
     static get _isWindows() {
@@ skipping 76 matching lines @@
           let pathSegments = path[dartx.split](sep);
           Uri._checkWindowsPathReservedCharacters(pathSegments, true);
           return Uri.new({scheme: "file", pathSegments: pathSegments});
         }
       } else {
         let pathSegments = path[dartx.split](sep);
         Uri._checkWindowsPathReservedCharacters(pathSegments, true);
         return Uri.new({pathSegments: pathSegments});
       }
     }
-    replace(opts) {
-      let scheme = opts && 'scheme' in opts ? opts.scheme : null;
-      let userInfo = opts && 'userInfo' in opts ? opts.userInfo : null;
-      let host = opts && 'host' in opts ? opts.host : null;
-      let port = opts && 'port' in opts ? opts.port : null;
-      let path = opts && 'path' in opts ? opts.path : null;
-      let pathSegments = opts && 'pathSegments' in opts ? opts.pathSegments : null;
-      let query = opts && 'query' in opts ? opts.query : null;
-      let queryParameters = opts && 'queryParameters' in opts ? opts.queryParameters : null;
-      let fragment = opts && 'fragment' in opts ? opts.fragment : null;
+    replace({scheme = null, userInfo = null, host = null, port = null, path = null, pathSegments = null, query = null, queryParameters = null, fragment = null} = {}) {
       let schemeChanged = false;
       if (scheme != null) {
         scheme = Uri._makeScheme(scheme, scheme[dartx.length]);
         schemeChanged = true;
       } else {
         scheme = this.scheme;
       }
       let isFile = scheme == "file";
       if (userInfo != null) {
         userInfo = Uri._makeUserInfo(userInfo, 0, userInfo[dartx.length]);
@@ skipping 486 matching lines @@
       if (this.scheme == "" || this[_host] == null || this[_host] == "") {
         dart.throw(new StateError(`Cannot use origin without a scheme: ${this}`));
       }
       if (this.scheme != "http" && this.scheme != "https") {
         dart.throw(new StateError(`Origin is only applicable schemes http and https: ${this}`));
       }
       if (this[_port] == null)
         return `${this.scheme}://${this[_host]}`;
       return `${this.scheme}://${this[_host]}:${this[_port]}`;
     }
-    toFilePath(opts) {
-      let windows = opts && 'windows' in opts ? opts.windows : null;
+    toFilePath({windows = null} = {}) {
       if (this.scheme != "" && this.scheme != "file") {
         dart.throw(new UnsupportedError(`Cannot extract a file path from a ${this.scheme} URI`));
       }
       if (this.query != "") {
         dart.throw(new UnsupportedError("Cannot extract a file path from a URI with a query component"));
       }
       if (this.fragment != "") {
         dart.throw(new UnsupportedError("Cannot extract a file path from a URI with a fragment component"));
       }
       if (windows == null)
@@ skipping 84 matching lines @@
     }
     static _addIfNonEmpty(sb, test, first, second) {
       if ("" != test) {
         sb.write(first);
         sb.write(second);
       }
     }
     static encodeComponent(component) {
       return Uri._uriEncode(dart.as(Uri._unreserved2396Table, List$(int)), component);
     }
-    static encodeQueryComponent(component, opts) {
-      let encoding = opts && 'encoding' in opts ? opts.encoding : convert.UTF8;
+    static encodeQueryComponent(component, {encoding = convert.UTF8} = {}) {
       return Uri._uriEncode(dart.as(Uri._unreservedTable, List$(int)), component, {encoding: encoding, spaceToPlus: true});
     }
     static decodeComponent(encodedComponent) {
       return Uri._uriDecode(encodedComponent);
     }
-    static decodeQueryComponent(encodedComponent, opts) {
-      let encoding = opts && 'encoding' in opts ? opts.encoding : convert.UTF8;
+    static decodeQueryComponent(encodedComponent, {encoding = convert.UTF8} = {}) {
       return Uri._uriDecode(encodedComponent, {plusToSpace: true, encoding: encoding});
     }
     static encodeFull(uri) {
       return Uri._uriEncode(dart.as(Uri._encodeFullTable, List$(int)), uri);
     }
     static decodeFull(uri) {
       return Uri._uriDecode(uri);
     }
-    static splitQueryString(query, opts) {
-      let encoding = opts && 'encoding' in opts ? opts.encoding : convert.UTF8;
+    static splitQueryString(query, {encoding = convert.UTF8} = {}) {
       return dart.as(query[dartx.split]("&")[dartx.fold](dart.map(), dart.fn((map, element) => {
         let index = dart.as(dart.dsend(element, 'indexOf', "="), int);
         if (index == -1) {
           if (!dart.equals(element, "")) {
             dart.dsetindex(map, Uri.decodeQueryComponent(dart.as(element, String), {encoding: encoding}), "");
           }
         } else if (index != 0) {
           let key = dart.dsend(element, 'substring', 0, index);
           let value = dart.dsend(element, 'substring', dart.notNull(index) + 1);
           dart.dsetindex(map, Uri.decodeQueryComponent(dart.as(key, String), {encoding: encoding}), Uri.decodeQueryComponent(dart.as(value, String), {encoding: encoding}));
@@ skipping 108 matching lines @@
             index = dart.notNull(index) + 2;
           }
         } else {
           bytes[dartx.set](index, dart.notNull(value) >> 8);
           bytes[dartx.set](dart.notNull(index) + 1, dart.notNull(value) & 255);
           index = dart.notNull(index) + 2;
         }
       }
       return dart.as(bytes, List$(int));
     }
-    static _uriEncode(canonicalTable, text, opts) {
-      let encoding = opts && 'encoding' in opts ? opts.encoding : convert.UTF8;
-      let spaceToPlus = opts && 'spaceToPlus' in opts ? opts.spaceToPlus : false;
+    static _uriEncode(canonicalTable, text, {encoding = convert.UTF8, spaceToPlus = false} = {}) {
       function byteToHex(byte, buffer) {
         let hex = '0123456789ABCDEF';
         dart.dsend(buffer, 'writeCharCode', hex[dartx.codeUnitAt](dart.as(dart.dsend(byte, '>>', 4), int)));
         dart.dsend(buffer, 'writeCharCode', hex[dartx.codeUnitAt](dart.as(dart.dsend(byte, '&', 15), int)));
       }
       dart.fn(byteToHex);
       let result = new StringBuffer();
       let bytes = encoding.encode(text);
       for (let i = 0; dart.notNull(i) < dart.notNull(bytes[dartx.length]); i = dart.notNull(i) + 1) {
         let byte = bytes[dartx.get](i);
@@ skipping 18 matching lines @@
           charCode = dart.notNull(charCode) | 32;
           if (97 <= dart.notNull(charCode) && dart.notNull(charCode) <= 102) {
             byte = dart.notNull(byte) * 16 + dart.notNull(charCode) - 87;
           } else {
             dart.throw(new ArgumentError("Invalid URL encoding"));
           }
         }
       }
       return byte;
     }
-    static _uriDecode(text, opts) {
-      let plusToSpace = opts && 'plusToSpace' in opts ? opts.plusToSpace : false;
-      let encoding = opts && 'encoding' in opts ? opts.encoding : convert.UTF8;
+    static _uriDecode(text, {plusToSpace = false, encoding = convert.UTF8} = {}) {
       let simple = true;
       for (let i = 0; dart.notNull(i) < dart.notNull(text[dartx.length]) && dart.notNull(simple); i = dart.notNull(i) + 1) {
         let codeUnit = text[dartx.codeUnitAt](i);
         simple = codeUnit != Uri._PERCENT && codeUnit != Uri._PLUS;
       }
       let bytes = null;
       if (dart.notNull(simple)) {
         if (dart.equals(encoding, convert.UTF8) || dart.equals(encoding, convert.LATIN1)) {
           return text;
         } else {
@@ skipping 196 matching lines @@
   exports.StackTrace = StackTrace;
   exports.Stopwatch = Stopwatch;
   exports.String = String;
   exports.RuneIterator = RuneIterator;
   exports.StringBuffer = StringBuffer;
   exports.StringSink = StringSink;
   exports.Symbol = Symbol;
   exports.Type = Type;
   exports.Uri = Uri;
 });