Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: lib/runtime/dart/_interceptors.js

Issue 1484263002: Use destructuring assignments for named parameters (#180) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Destructure function params directly (no more opts in most cases) Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/_internal.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 dart_library.library('dart/_interceptors', null, /* Imports */[ 1 dart_library.library('dart/_interceptors', null, /* Imports */[
2 "dart/_runtime", 2 "dart/_runtime",
3 'dart/core', 3 'dart/core',
4 'dart/_internal', 4 'dart/_internal',
5 'dart/collection', 5 'dart/collection',
6 'dart/math' 6 'dart/math'
7 ], /* Lazy imports */[ 7 ], /* Lazy imports */[
8 'dart/_js_helper' 8 'dart/_js_helper'
9 ], function(exports, dart, core, _internal, collection, math, _js_helper) { 9 ], function(exports, dart, core, _internal, collection, math, _js_helper) {
10 'use strict'; 10 'use strict';
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 return new (_internal.IterableMixinWorkaround$(E))().skipWhile(this, tes t); 201 return new (_internal.IterableMixinWorkaround$(E))().skipWhile(this, tes t);
202 } 202 }
203 [dartx.reduce](combine) { 203 [dartx.reduce](combine) {
204 dart.as(combine, dart.functionType(E, [E, E])); 204 dart.as(combine, dart.functionType(E, [E, E]));
205 return dart.as(_internal.IterableMixinWorkaround.reduce(this, combine), E); 205 return dart.as(_internal.IterableMixinWorkaround.reduce(this, combine), E);
206 } 206 }
207 [dartx.fold](initialValue, combine) { 207 [dartx.fold](initialValue, combine) {
208 dart.as(combine, dart.functionType(dart.dynamic, [dart.dynamic, E])); 208 dart.as(combine, dart.functionType(dart.dynamic, [dart.dynamic, E]));
209 return _internal.IterableMixinWorkaround.fold(this, initialValue, combin e); 209 return _internal.IterableMixinWorkaround.fold(this, initialValue, combin e);
210 } 210 }
211 [dartx.firstWhere](test, opts) { 211 [dartx.firstWhere](test, {orElse = null} = {}) {
212 dart.as(test, dart.functionType(core.bool, [E])); 212 dart.as(test, dart.functionType(core.bool, [E]));
213 let orElse = opts && 'orElse' in opts ? opts.orElse : null;
214 dart.as(orElse, dart.functionType(E, [])); 213 dart.as(orElse, dart.functionType(E, []));
215 return dart.as(_internal.IterableMixinWorkaround.firstWhere(this, test, orElse), E); 214 return dart.as(_internal.IterableMixinWorkaround.firstWhere(this, test, orElse), E);
216 } 215 }
217 [dartx.lastWhere](test, opts) { 216 [dartx.lastWhere](test, {orElse = null} = {}) {
218 dart.as(test, dart.functionType(core.bool, [E])); 217 dart.as(test, dart.functionType(core.bool, [E]));
219 let orElse = opts && 'orElse' in opts ? opts.orElse : null;
220 dart.as(orElse, dart.functionType(E, [])); 218 dart.as(orElse, dart.functionType(E, []));
221 return dart.as(_internal.IterableMixinWorkaround.lastWhereList(this, tes t, orElse), E); 219 return dart.as(_internal.IterableMixinWorkaround.lastWhereList(this, tes t, orElse), E);
222 } 220 }
223 [dartx.singleWhere](test) { 221 [dartx.singleWhere](test) {
224 dart.as(test, dart.functionType(core.bool, [E])); 222 dart.as(test, dart.functionType(core.bool, [E]));
225 return dart.as(_internal.IterableMixinWorkaround.singleWhere(this, test) , E); 223 return dart.as(_internal.IterableMixinWorkaround.singleWhere(this, test) , E);
226 } 224 }
227 [dartx.elementAt](index) { 225 [dartx.elementAt](index) {
228 return this[dartx.get](index); 226 return this[dartx.get](index);
229 } 227 }
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 } 336 }
339 get [dartx.isEmpty]() { 337 get [dartx.isEmpty]() {
340 return this[dartx.length] == 0; 338 return this[dartx.length] == 0;
341 } 339 }
342 get [dartx.isNotEmpty]() { 340 get [dartx.isNotEmpty]() {
343 return !dart.notNull(this[dartx.isEmpty]); 341 return !dart.notNull(this[dartx.isEmpty]);
344 } 342 }
345 toString() { 343 toString() {
346 return collection.ListBase.listToString(this); 344 return collection.ListBase.listToString(this);
347 } 345 }
348 [dartx.toList](opts) { 346 [dartx.toList]({growable = true} = {}) {
349 let growable = opts && 'growable' in opts ? opts.growable : true;
350 let list = this.slice(); 347 let list = this.slice();
351 if (!dart.notNull(growable)) 348 if (!dart.notNull(growable))
352 JSArray$().markFixedList(dart.as(list, core.List)); 349 JSArray$().markFixedList(dart.as(list, core.List));
353 return JSArray$(E).typed(list); 350 return JSArray$(E).typed(list);
354 } 351 }
355 [dartx.toSet]() { 352 [dartx.toSet]() {
356 return core.Set$(E).from(this); 353 return core.Set$(E).from(this);
357 } 354 }
358 get [dartx.iterator]() { 355 get [dartx.iterator]() {
359 return new (_internal.ListIterator$(E))(this); 356 return new (_internal.ListIterator$(E))(this);
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
998 return false; 995 return false;
999 return other == this[dartx.substring](dart.notNull(this[dartx.length]) - d art.notNull(otherLength)); 996 return other == this[dartx.substring](dart.notNull(this[dartx.length]) - d art.notNull(otherLength));
1000 } 997 }
1001 [dartx.replaceAll](from, to) { 998 [dartx.replaceAll](from, to) {
1002 _js_helper.checkString(to); 999 _js_helper.checkString(to);
1003 return dart.as(_js_helper.stringReplaceAllUnchecked(this, from, to), core. String); 1000 return dart.as(_js_helper.stringReplaceAllUnchecked(this, from, to), core. String);
1004 } 1001 }
1005 [dartx.replaceAllMapped](from, convert) { 1002 [dartx.replaceAllMapped](from, convert) {
1006 return this[dartx.splitMapJoin](from, {onMatch: convert}); 1003 return this[dartx.splitMapJoin](from, {onMatch: convert});
1007 } 1004 }
1008 [dartx.splitMapJoin](from, opts) { 1005 [dartx.splitMapJoin](from, {onMatch = null, onNonMatch = null} = {}) {
1009 let onMatch = opts && 'onMatch' in opts ? opts.onMatch : null;
1010 let onNonMatch = opts && 'onNonMatch' in opts ? opts.onNonMatch : null;
1011 return dart.as(_js_helper.stringReplaceAllFuncUnchecked(this, from, onMatc h, onNonMatch), core.String); 1006 return dart.as(_js_helper.stringReplaceAllFuncUnchecked(this, from, onMatc h, onNonMatch), core.String);
1012 } 1007 }
1013 [dartx.replaceFirst](from, to, startIndex) { 1008 [dartx.replaceFirst](from, to, startIndex) {
1014 if (startIndex === void 0) 1009 if (startIndex === void 0)
1015 startIndex = 0; 1010 startIndex = 0;
1016 _js_helper.checkString(to); 1011 _js_helper.checkString(to);
1017 _js_helper.checkInt(startIndex); 1012 _js_helper.checkInt(startIndex);
1018 if (dart.notNull(startIndex) < 0 || dart.notNull(startIndex) > dart.notNul l(this[dartx.length])) { 1013 if (dart.notNull(startIndex) < 0 || dart.notNull(startIndex) > dart.notNul l(this[dartx.length])) {
1019 dart.throw(new core.RangeError.range(startIndex, 0, this[dartx.length])) ; 1014 dart.throw(new core.RangeError.range(startIndex, 0, this[dartx.length])) ;
1020 } 1015 }
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
1502 exports.JSString = JSString; 1497 exports.JSString = JSString;
1503 exports.getInterceptor = getInterceptor; 1498 exports.getInterceptor = getInterceptor;
1504 exports.JSBool = JSBool; 1499 exports.JSBool = JSBool;
1505 exports.JSIndexable = JSIndexable; 1500 exports.JSIndexable = JSIndexable;
1506 exports.JSMutableIndexable = JSMutableIndexable; 1501 exports.JSMutableIndexable = JSMutableIndexable;
1507 exports.JSObject = JSObject; 1502 exports.JSObject = JSObject;
1508 exports.JavaScriptObject = JavaScriptObject; 1503 exports.JavaScriptObject = JavaScriptObject;
1509 exports.PlainJavaScriptObject = PlainJavaScriptObject; 1504 exports.PlainJavaScriptObject = PlainJavaScriptObject;
1510 exports.UnknownJavaScriptObject = UnknownJavaScriptObject; 1505 exports.UnknownJavaScriptObject = UnknownJavaScriptObject;
1511 }); 1506 });
OLDNEW
« no previous file with comments | « no previous file | lib/runtime/dart/_internal.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698