Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: build/android/devil/android/device_utils.py

Issue 1484253003: [Android] Add record functionality to logcat monitor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass device serials to LogcatMonitorCommandErrors. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/devil/android/logcat_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/devil/android/device_utils.py
diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py
index 6844bf0502050fea4ffe4388a0f92131af64d582..41b86fbc6b4541b60277b019ce34abbfd603155e 100644
--- a/build/android/devil/android/device_utils.py
+++ b/build/android/devil/android/device_utils.py
@@ -1985,16 +1985,11 @@ class DeviceUtils(object):
raise device_errors.CommandFailedError(
'Could not find memory peak value for pid %s', str(pid))
- @decorators.WithTimeoutAndRetriesFromInstance()
- def GetLogcatMonitor(self, timeout=None, retries=None, *args, **kwargs):
+ def GetLogcatMonitor(self, *args, **kwargs):
"""Returns a new LogcatMonitor associated with this device.
Parameters passed to this function are passed directly to
|logcat_monitor.LogcatMonitor| and are documented there.
-
- Args:
- timeout: timeout in seconds
- retries: number of retries
"""
return logcat_monitor.LogcatMonitor(self.adb, *args, **kwargs)
« no previous file with comments | « no previous file | build/android/devil/android/logcat_monitor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698