Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 148423004: Only report bounding box touch hit rect for non-composited scroll layers. (Closed)

Created:
6 years, 10 months ago by Zeeshan Qureshi
Modified:
6 years, 10 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering
Visibility:
Public.

Description

Compositor touch hit rects report unnecessary rects for non-composited scrolling layers A non-composited scrolling layer will get projected to the same compositing layer as its bounding box so to make its visualization easier don't report m_scrollableArea->overflowRect(). BUG=337844 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166084

Patch Set 1 #

Patch Set 2 : Update test description #

Total comments: 1

Messages

Total messages: 9 (0 generated)
Zeeshan Qureshi
6 years, 10 months ago (2014-01-27 23:39:46 UTC) #1
Rick Byers
LGTM, this is great - thanks Zeeshan! I'd suggest mentioning in your description that it ...
6 years, 10 months ago (2014-01-29 17:46:23 UTC) #2
leviw_travelin_and_unemployed
Code change lgtm! Please copy the bug title into the description (otherwise it won't be ...
6 years, 10 months ago (2014-01-29 17:59:10 UTC) #3
Zeeshan Qureshi
Updated description.
6 years, 10 months ago (2014-01-29 18:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/148423004/10001
6 years, 10 months ago (2014-01-29 18:16:23 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-01-30 06:00:23 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 06:00:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/148423004/10001
6 years, 10 months ago (2014-01-30 06:01:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:01:59 UTC) #9
Message was sent while issue was closed.
Change committed as 166084

Powered by Google App Engine
This is Rietveld 408576698