Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1484223002: Move transform-origin property into CSSPropertyParser (Closed)

Created:
5 years ago by rwlbuis
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move transform-origin property into CSSPropertyParser Move transform-origin property handling from LegacyCSSPropertyParser into CSSPropertyParser. This patch uses functionality from <position> parsing helper methods where possible. BUG=499780 Committed: https://crrev.com/19de783f0ae8da743e7461635cace4b6dec93c14 Cr-Commit-Position: refs/heads/master@{#363207}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Base on perspective-origin's work #

Patch Set 4 : Patch for review #

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -89 lines) Patch
M third_party/WebKit/LayoutTests/transforms/transform-origin-parsing.html View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 2 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 3 chunks +1 line, -79 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
rwlbuis
PTAL.
5 years ago (2015-12-04 04:21:01 UTC) #5
Timothy Loh
On 2015/12/04 04:21:01, rwlbuis wrote: > PTAL. lgtm
5 years ago (2015-12-04 04:33:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484223002/80001
5 years ago (2015-12-04 12:08:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/144817) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-04 12:10:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484223002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484223002/100001
5 years ago (2015-12-04 13:11:01 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years ago (2015-12-04 14:41:26 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-04 14:42:31 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/19de783f0ae8da743e7461635cace4b6dec93c14
Cr-Commit-Position: refs/heads/master@{#363207}

Powered by Google App Engine
This is Rietveld 408576698