Added key binding for the overtype mode

Added key binding for the overtype mode

Set up the Insert key to trigger the OverWrite editing command and thus enable/disable the overtype mode.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150906

[svillar, 2013-05-20 17:07:55]

ping reviewers

[eseidel, 2013-05-20 19:30:35]

Is this a web-observable change?  do we have tests for overwrite mode?  Can we
test this?

[svillar, 2013-05-21 07:08:53]

On 2013/05/20 19:30:35, eseidel wrote:
> Is this a web-observable change?  do we have tests for overwrite mode?  Can we
> test this?

Yes it's observable. The behavior of typing is modified as the typed text
replaces the existing one instead of inserting. Apart from that if
https://codereview.chromium.org/14859008/ is accepted, the caret will be
replaced with a block cursor that will cover the next character to be replaced.
It's implemented so it works even with bidi text.

Regarding tests, there are currently 2 tests:
editing/execCommand/overtype.html
editing/execCommand/overtype-support.html

and the change I mentioned above adds another one:
editing/selection/block-cursor-overtype-mode.html

[eseidel, 2013-05-22 07:48:32]

So do those tests need rebaselining with this change?

[svillar, 2013-05-22 07:59:16]

On 2013/05/22 07:48:32, eseidel wrote:
> So do those tests need rebaselining with this change?

No, not at all. I added overtype mode to webkit in
http://trac.webkit.org/changeset/146907 so before the Blink fork. Overtype mode
has been part of Blink since the very beginning :).

Those tests are using window.internals, so they don't really need this change at
all. Consider this CL as a way to "unveil" to the users a feature that was
already there.

[eseidel, 2013-05-22 08:11:18]

lgtm

[commit-bot: I haz the power, 2013-05-22 08:11:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/svillar@igalia.com/14842018/1

[commit-bot: I haz the power, 2013-05-22 09:02:48]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-22 15:18:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/svillar@igalia.com/14842018/1

[commit-bot: I haz the power, 2013-05-22 16:04:32]

Change committed as 150906