Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1484163003: [crankshaft] Prevent inlining of new.target functions. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Prevent inlining of new.target functions. This moves the bailout for functions containing new.target variable to the correct place so that Crankshaft doesn't accidentally inline such functions, yielding an "undefined" new.target value all the time. R=bmeurer@chromium.org TEST=mjsunit/es6/regress/regress-inlined-new-target Committed: https://crrev.com/8c793fed78034851c09d4c8d03e22783f5bb9d64 Cr-Commit-Position: refs/heads/master@{#32468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-inlined-new-target.js View 1 chunk +5 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Benedikt: PTAL. Adam: FYI.
5 years ago (2015-12-01 13:52:41 UTC) #2
Benedikt Meurer
LGTM *heul*
5 years ago (2015-12-01 13:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484163003/1
5 years ago (2015-12-01 14:09:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 14:19:28 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 14:19:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c793fed78034851c09d4c8d03e22783f5bb9d64
Cr-Commit-Position: refs/heads/master@{#32468}

Powered by Google App Engine
This is Rietveld 408576698