cc/debug/rasterize_and_record_benchmark.cc - Issue 1484163002: Raster display item lists via a visual rect RTree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/rasterize_and_record_benchmark.cc

Issue 1484163002: Raster display item lists via a visual rect RTree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/debug/rasterize_and_record_benchmark.cc

diff --git a/cc/debug/rasterize_and_record_benchmark.cc b/cc/debug/rasterize_and_record_benchmark.cc

index 5babc0edca6a11a1450da3e780d0721ec0a06e88..4e4013236a84294ac053b5b9f16dae1e296c4c55 100644

--- a/cc/debug/rasterize_and_record_benchmark.cc

+++ b/cc/debug/rasterize_and_record_benchmark.cc

@@ -161,7 +161,7 @@ void RasterizeAndRecordBenchmark::RunOnLayer(PictureLayer* layer) {

if (display_list->ShouldBeAnalyzedForSolidColor()) {

gfx::Size layer_size = layer->paint_properties().bounds;

skia::AnalysisCanvas canvas(layer_size.width(), layer_size.height());

- display_list->Raster(&canvas, nullptr, gfx::Rect(), 1.f);

+ display_list->Raster(&canvas, nullptr, gfx::Rect(layer_size), 1.f);

}

if (memory_used) {