Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 1484143003: Clear the HTTP auth state when clearing cookies or cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile_impl_io_data.h" 5 #include "chrome/browser/profiles/profile_impl_io_data.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 ProfileImplIOData::AcquireIsolatedMediaRequestContext( 771 ProfileImplIOData::AcquireIsolatedMediaRequestContext(
772 net::URLRequestContext* app_context, 772 net::URLRequestContext* app_context,
773 const StoragePartitionDescriptor& partition_descriptor) const { 773 const StoragePartitionDescriptor& partition_descriptor) const {
774 // We create per-app media contexts on demand, unlike the others above. 774 // We create per-app media contexts on demand, unlike the others above.
775 net::URLRequestContext* media_request_context = 775 net::URLRequestContext* media_request_context =
776 InitializeMediaRequestContext(app_context, partition_descriptor); 776 InitializeMediaRequestContext(app_context, partition_descriptor);
777 DCHECK(media_request_context); 777 DCHECK(media_request_context);
778 return media_request_context; 778 return media_request_context;
779 } 779 }
780 780
781 void ProfileImplIOData::ClearNetworkingHistorySinceOnIOThread( 781 void ProfileImplIOData::ClearNetworkingHistorySinceOnIOThread(
mmenke 2015/12/01 15:59:48 Hrm...Is this really part of the network history?
msramek 2015/12/01 16:26:04 The HTTP cache is deleted straight from BrowsingDa
asanka 2015/12/01 17:51:10 Putting this in ClearNetworkHistorySinceOnIOThread
mmenke 2015/12/01 17:59:32 That sounds reasonable to me, at least.
782 base::Time time, 782 base::Time time,
783 const base::Closure& completion) { 783 const base::Closure& completion) {
784 DCHECK_CURRENTLY_ON(BrowserThread::IO); 784 DCHECK_CURRENTLY_ON(BrowserThread::IO);
785 DCHECK(initialized()); 785 DCHECK(initialized());
786 786
787 // Synchronous deletion.
787 DCHECK(transport_security_state()); 788 DCHECK(transport_security_state());
788 // Completes synchronously.
789 transport_security_state()->DeleteAllDynamicDataSince(time); 789 transport_security_state()->DeleteAllDynamicDataSince(time);
790 DCHECK(http_network_session_.get());
791 http_network_session_->http_auth_cache()->Clear();
mmenke 2015/12/01 15:59:48 I don't think it makes much sense to clear auth in
msramek 2015/12/01 16:26:04 Ok, I'll look into it! (I'm not very familiar with
asanka 2015/12/01 17:51:10 Also, this is meant to delete state since |time|.
792
793 // Asynchronous deletion, calls the |completion| callback when finished.
790 DCHECK(http_server_properties_manager_); 794 DCHECK(http_server_properties_manager_);
791 http_server_properties_manager_->Clear(completion); 795 http_server_properties_manager_->Clear(completion);
792 } 796 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698