components/autofill/core/browser/autofill_popup_delegate.h - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_popup_delegate.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update code as per Ilya's comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate_unittest.cc ('k') | components/autofill/core/browser/test_autofill_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_popup_delegate.h

diff --git a/components/autofill/core/browser/autofill_popup_delegate.h b/components/autofill/core/browser/autofill_popup_delegate.h

index dec139cfb83cebfce27aad03389cb996b28cb722..b94b33a9747b530f4f2b562b3affb72a5af129bc 100644

--- a/components/autofill/core/browser/autofill_popup_delegate.h

+++ b/components/autofill/core/browser/autofill_popup_delegate.h

@@ -29,7 +29,8 @@ class AutofillPopupDelegate {

// Called when the autofill suggestion indicated by |identifier| has been

// temporarily selected (e.g., hovered).

- virtual void DidSelectSuggestion(int identifier) = 0;

+ virtual void DidSelectSuggestion(const base::string16& value,

+ int identifier) = 0;

// Inform the delegate that a row in the popup has been chosen.

virtual void DidAcceptSuggestion(const base::string16& value,