components/autofill/core/browser/autofill_driver.h - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_driver.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update code as per Ilya's comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/core/browser/autofill_external_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_driver.h

diff --git a/components/autofill/core/browser/autofill_driver.h b/components/autofill/core/browser/autofill_driver.h

index e9981706c8ab9b6b35ca0a32b8ef009f726fd866..629d85f8a5bbf8c51f30935df4a2d116e1574eba 100644

--- a/components/autofill/core/browser/autofill_driver.h

+++ b/components/autofill/core/browser/autofill_driver.h

@@ -80,7 +80,13 @@ class AutofillDriver {

virtual void RendererShouldClearPreviewedForm() = 0;

// Tells the renderer to set the node text.

- virtual void RendererShouldSetNodeText(const base::string16& value) = 0;

+ virtual void RendererShouldFillFieldWithValue(

+ const base::string16& value) = 0;

+ // Tells the renderer to preview the node with suggested text.

+ virtual void RendererShouldPreviewFieldWithValue(

+ const base::string16& value) = 0;

};

} // namespace autofill