Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and update code as per Ilya's comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index dc9df2309990ad8041e791c71e7f308fe5fbfb09..d435bf438bacfa27adc5f447dfe12bdd84ecaf13 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -97,7 +97,8 @@ class AutofillAgent : public content::RenderViewObserver,
// For external Autofill selection.
void OnClearForm();
void OnClearPreviewedForm();
- void OnSetNodeText(const base::string16& value);
+ void OnFillFieldWithValue(const base::string16& value);
+ void OnPreviewFieldWithValue(const base::string16& value);
void OnAcceptDataListSuggestion(const base::string16& value);
void OnAcceptPasswordAutofillSuggestion(const base::string16& username);
@@ -151,7 +152,14 @@ class AutofillAgent : public content::RenderViewObserver,
FormFieldData* field) WARN_UNUSED_RESULT;
// Set |node| to display the given |value|.
- void SetNodeText(const base::string16& value, blink::WebInputElement* node);
+ void FillFieldWithValue(const base::string16& value,
+ blink::WebInputElement* node);
+
+ // Set |node| to display the given |value| as a preview. The preview is
+ // visible on screen to the user, but not visible to the page via the DOM or
+ // JavaScript.
+ void PreviewFieldWithValue(const base::string16& value,
+ blink::WebInputElement* node);
// Hides any currently showing Autofill popup.
void HidePopup();
« no previous file with comments | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698