components/autofill/content/browser/content_autofill_driver.h - Issue 148413002: Add "previewing on hover" support for single-field autocomplete input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update code as per Ilya's comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc ('k') | components/autofill/content/browser/content_autofill_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver.h

diff --git a/components/autofill/content/browser/content_autofill_driver.h b/components/autofill/content/browser/content_autofill_driver.h

index dcf1a5fa89292b0005f44b81a1f485ac76972ea0..a5076794d9828f2545ae1801b3c2261db157b921 100644

--- a/components/autofill/content/browser/content_autofill_driver.h

+++ b/components/autofill/content/browser/content_autofill_driver.h

@@ -58,7 +58,10 @@ class ContentAutofillDriver : public AutofillDriver,

const base::string16& username) OVERRIDE;

virtual void RendererShouldClearFilledForm() OVERRIDE;

virtual void RendererShouldClearPreviewedForm() OVERRIDE;

- virtual void RendererShouldSetNodeText(const base::string16& value) OVERRIDE;

+ virtual void RendererShouldFillFieldWithValue(

+ const base::string16& value) OVERRIDE;

+ virtual void RendererShouldPreviewFieldWithValue(

+ const base::string16& value) OVERRIDE;

// Returns the WebContents with which this instance is associated.

content::WebContents* GetWebContents();