Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 148413002: Add "previewing on hover" support for single-field autocomplete input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ilya's 2nd set comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/content/renderer/autofill_agent.cc ('K') | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | components/autofill/core/browser/autofill_external_delegate_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_external_delegate.h
diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h
index e399eb580044e3ab81d2cc31e9ee4a1ba6be3c51..5ed15856c05bfe77de85375f39b55c09114f143d 100644
--- a/components/autofill/core/browser/autofill_external_delegate.h
+++ b/components/autofill/core/browser/autofill_external_delegate.h
@@ -44,7 +44,8 @@ class AutofillExternalDelegate
virtual void OnPopupShown() OVERRIDE;
virtual void OnPopupHidden() OVERRIDE;
virtual bool ShouldRepostEvent(const ui::MouseEvent& event) OVERRIDE;
- virtual void DidSelectSuggestion(int identifier) OVERRIDE;
+ virtual void DidSelectSuggestion(const base::string16& value,
+ int identifier) OVERRIDE;
virtual void DidAcceptSuggestion(const base::string16& value,
int identifier) OVERRIDE;
virtual void RemoveSuggestion(const base::string16& value,
« components/autofill/content/renderer/autofill_agent.cc ('K') | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | components/autofill/core/browser/autofill_external_delegate_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698